-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caching isn't working #67
Comments
I mentioned on Slack, I don't repro "caching not working." There, you clarified that:
But that's not what I see.
As for your bulleted list, I don't think I agree with your list. Remembering that there are three kinds of caching (browser skips the request, browser revalidates stale content and gets
That's unwise, because then users will copy and paste URLs like |
Right, it's the nginx cache that isn't working. The HTML files, the 302 redirects, and the resources of https://2k788xeots.unbox.ifarchive.org/2k788xeots/www/index.html should all be cached, but aren't right now. Many HTML files are small, but some, for example https://0cvfuriysy.unbox.ifarchive.org/0cvfuriysy/Glitch%20Perfect.html are over 100MB! They definitely need to be cached by nginx. The redirects are less important, but might as well be.
I didn't mention |
(Btw, I didn't know you could show that I'd suggest you turn on the Domain column though, that would make clearer what's happening with https://2ckvcbhjia.unbox.ifarchive.org/2ckvcbhjia/index.html) |
Using For zip index pages and zipped HTML files, the unbox app server just has to read the I'm absolutely certain the server won't be hammered, because the server isn't hammered right now, even though nginx caching is totally busted! For what it's worth, we use |
I guess it should be fine; especially as the file details are all held in RAM, so it's very quick to return a 304. |
Desired behaviour: in general, our caches (Cloudflare, nginx) should cache things briefly (1 day? 6 hours?), while the user's browser should cache things longer (1 week? month?). (We can set different cache times by using both
max-age
ands-maxage
.) This reduces the time it takes for archive updates to reach the user (#64).Specifics:
?lastmod
We could consider doing more
?lastmod
stuff, such as automatically adding it to the links in index pages. But it's not really needed, and it's a detail I think would be better to hide from the user. (Using it for HTML game redirects is more hidden.)The text was updated successfully, but these errors were encountered: