Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lax libraries handling glk_request_char_event when the window has identical pending input #25

Open
curiousdannii opened this issue Dec 14, 2024 · 0 comments

Comments

@curiousdannii
Copy link
Member

So I've just discovered that Kerkerkruip causes a fatal error in some interpreters by calling glk_request_char_event when the window already has pending character events. I'm pretty sure that was my mistake, though as I was predominantly testing back then on Garglk and Windows Glk my mistake was enabled by lax interpreters. In Quixe and RemGlk-Rs it causes a fatal error. (RemGlk is probably the same.)

I'm thinking of updating RemGlk-Rs so that it ignores multiple calls to glk_request_char_event/_uni as long as the window already is waiting for the same type of input. That seems harmless. I'm not going to change glk_request_line_event, as even if it was called with the same buffer it seems too risky to overwrite it.

I'm filing an issue here in case you think it's worth adding a note that some games expect lax Glk libraries.

(I've also just seen that Windows Glk doesn't seem to be accepting keyboard input in the Kerkerkruip menu. Don't know what's up with that.)

@curiousdannii curiousdannii changed the title Softening calling glk_request_char_event when the window has identical pending input? Lax libraries handling glk_request_char_event when the window has identical pending input Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant