Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darkmode.js isn't checked in #51

Open
dfabulich opened this issue Nov 1, 2024 · 1 comment
Open

darkmode.js isn't checked in #51

dfabulich opened this issue Nov 1, 2024 · 1 comment

Comments

@dfabulich
Copy link
Contributor

dfabulich commented Nov 1, 2024

I get an (ignorable) 404 error on every page load in the test environment because I don't have darkmode.js.

@erkyrath
Copy link
Member

erkyrath commented Nov 1, 2024

Ah right. That file lives in the ifarchive-static repo: https://github.com/iftechfoundation/ifarchive-static/blob/main/misc/darkmode.js

We could copy it in, same as admintool.css. But as you see there's a somewhat clunky config file variable (AppCSSURI) which sets the path of admintool.css in templates/page.html. The darkmode.js file has no such variable; it's on a fixed path.

If you think it's worth fixing the error, we can set up an AppJSURI variable in the same way.

(Or, I guess, adjust the Docker script to copy that file into /misc on the test server.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants