Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change URI.escape with something else #5

Open
tagliala opened this issue Aug 2, 2021 · 1 comment
Open

Change URI.escape with something else #5

tagliala opened this issue Aug 2, 2021 · 1 comment

Comments

@tagliala
Copy link
Member

tagliala commented Aug 2, 2021

carrierwave-colore/lib/carrierwave/storage/colore.rb

Line 80 in 3b3bdc7

filename: URI.escape(new_file.filename),

carrierwave-colore/lib/carrierwave/storage/colore.rb

Line 83 in 3b3bdc7

@filename = URI.escape(response["path"])

carrierwave-colore/lib/carrierwave/storage/colore.rb

Line 144 in 3b3bdc7

filename: URI.escape(@filename) 

~/.rvm/gems/ruby-2.7.2/bundler/gems/carrierwave-colore-3b3bdc7b285f/lib/carrierwave/storage/colore.rb:144: warning: URI.escape is obsolete
~/.rvm/gems/ruby-2.7.2/bundler/gems/carrierwave-colore-3b3bdc7b285f/lib/carrierwave/storage/colore.rb:144: warning: URI.escape is obsolete
.............................................~/.rvm/gems/ruby-2.7.2/bundler/gems/carrierwave-colore-3b3bdc7b285f/lib/carrierwave/storage/colore.rb:80: warning: URI.escape is obsolete
~/.rvm/gems/ruby-2.7.2/bundler/gems/carrierwave-colore-3b3bdc7b285f/lib/carrierwave/storage/colore.rb:83: warning: URI.escape is obsolete
@tagliala
Copy link
Member Author

tagliala commented Oct 3, 2021

We can add addressable as a runtime dependency and use Addressable::URI.encode_component(url)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tagliala