-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth48 #515
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure of the intended use of this. Is it mainly a base for applying XML changes? Is the content equivalent to the current level from the RFC editors? It looks like many of the files are generated from the XML, presumably just to give a more granular way of viewing changes.
Should we now create PRs relative to the auth48 branch? Not sure how to do that. Clearly, I can (at least in principle) edit the XML, but how to generate the rest?
On 2024-02-12, at 15:41, Glyn Normington ***@***.***> wrote:
@glyn approved this pull request.
Well, we aren’t done yet :-)
Not sure of the intended use of this. Is it mainly a base for applying XML changes?
Yes. None are in yet.
Is the content equivalent to the current level from the RFC editors? It looks like many of the files are generated from the XML, presumably just to give a more granular way of viewing changes.
The other files are for check-abnf.
Should we now create PRs relative to the auth48 branch? Not sure how to do that. Clearly, I can (at least in principle) edit the XML, but how to generate the rest?
I was planning to simply edit the rfc9535.xml based on the diff lists we now have; the other files are just helping to do consistency checks (they are created from the check-abnf script, but I committed them so we don’t overlook changes).
Grüße, Carsten
|
(After correcting it to 2.3.1.1, it would become a meaningless self-reference.)
And clarify whose notation this sentence is about.
(We use "evaluate" sparingly, and it is not needed at all here to further qualify "produce".)
@@ -449,7 +449,7 @@ $.store.book[[email protected] < 10].title | |||
| `..name` | shorthand for `..['name']` | | |||
| `..*` | shorthand for `..[*]` | | |||
| `'name'` | [name selector](#name-selector): selects a named child of an object | | |||
| `*` | [wildcard selector](#name-selector): selects all children of a node | | |||
| `*` | [wildcard selector](#wildcard-selector): selects all children of a node | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cabo Good catch!
summing with -> adding to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes up to G10 looking good, thanks!
note that we don't have a definition for a sole "argument", but that is a standard term that has very little confusion attached to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another good set of changes, thanks, up to G1.
What became of G11?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All approved. Thanks!
I dropped G11 after discussion. |
@cabo do you have a link for the auth48 process and what these files are for? I thought auth48 was just final author approvals. |
Hi Greg, there is not a single document I could point to.
In summary, AUTH48 is for checking the RFC Production Center (RPC) edits between authors and RPC and making any editorial and technical changes necessary before publication. Since this is an approved document, any technical changes will be quite limited (essentially inconsequential for interoperability in this case). |
So why all the new files? What's the driver for these? I don't expect any technical changes, but I'm curious about the new files. |
The new files come from a script, check-abnf, that just checks whether any of the spacing fixes we made to the ABNF actually changed its contents. They are extracted from the XML via kramdown-rfc-extract-sourcecode. I was lazy and comitted all of those, even if I only care about the ABNF. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation, @cabo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5c10c5a LGTM, thanks.
@@ -72,7 +72,7 @@ | |||
<name>Introduction</name> | |||
<t>JSON <xref target="RFC8259"/> is a popular representation | |||
format for structured data values. | |||
JSONPath defines a string syntax for selecting and extracting JSON <xref target="RFC8259"/> values | |||
JSONPath defines a string syntax for selecting and extracting JSON values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that was a bit much!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C4 and C5 LGTM, thanks!
(We can't verify what was deprecated in 2014, which was 5 years after ES5 was released, replacing the ES4 proposal stalled in development.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C6, C1, C7 are good.
The word "strict" is used nowhere else but table 11. It serves no useful purpose here. (It might have been meant to distinguish strict inequalities (<) from non-strict (<=) ones, but extracting that intention is too much of a transfer for the reader.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C8 is just what I would have done.
The text in 2.4.8 (value()) apparently wasn't updated when we stopped talking about "Nothing" for nodelists (these are now simply "empty").
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C9 was a corker. Thanks for fixing.
I'm now planning to keep this as a draft pull request until the RFC is published. |
Files for completing AUTH48 process