Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make SQA link to neml submodule, an full path value #404

Open
milljm opened this issue Nov 20, 2024 · 0 comments · May be fixed by #405
Open

make SQA link to neml submodule, an full path value #404

milljm opened this issue Nov 20, 2024 · 0 comments · May be fixed by #405
Assignees
@milljm

Comments

@milljm
Copy link
Member

milljm commented Nov 20, 2024

Reason

An incoming change: idaholab/moose#29100, will require a full path when determining what 'neml' to use for identifying purposes in documentation.

Error:

TOKENIZE ERROR: The submodule 'neml' was not located, the available submodules are: contrib/neml, contrib/neml/pybind11, moose
/data/civet0/build/blackbear/doc/content/sqa/blackbear_sll.md:10
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
10│[!git!submodule-hash url=https://github.com/Argonne-National-Laboratory/neml/commit](neml)      │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
Traceback (most recent call last):

Design

-Current Version of NEML: [!git!submodule-hash url=https://github.com/Argonne-National-Laboratory/neml/commit](neml)
+Current Version of NEML: [!git!submodule-hash url=https://github.com/Argonne-National-Laboratory/neml/commit](contrib/neml)

Impact

Documentation will not by accident use a nested submodule of the same name perhaps listed earlier than the intended target.
@milljm milljm self-assigned this Nov 20, 2024
milljm added a commit that referenced this issue Nov 20, 2024
@milljm
Use full relative path for neml submodule
a7037d3 
Declare the full relative path where neml lives: contrib/neml

Closes #404
@milljm milljm linked a pull request Nov 20, 2024 that will close this issue
Open
@milljm milljm changed the title make SQA link to moose submodule, an full path value make SQA link to neml submodule, an full path value Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@milljm milljm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use full relative path for neml submodule idaholab/blackbear
1 participant
@milljm