Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic update of urdf triggered by GitHub Action #159

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Automatic update of urdf triggered by GitHub Action #159

merged 1 commit into from
Aug 8, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 7, 2023

This PR has been automatically triggered by committing to simmechanics files

@github-actions github-actions bot requested a review from Nicogene August 7, 2023 13:40
@Nicogene
Copy link
Member

Nicogene commented Aug 7, 2023

@traversaro these changes seem consistent to you?

@Nicogene Nicogene merged commit aae9cd6 into master Aug 8, 2023
@Nicogene Nicogene deleted the automatic-update-urdf-1691415618 branch August 8, 2023 10:03
@Nicogene
Copy link
Member

Nicogene commented Aug 8, 2023 •
edited
Loading

In case something is not right we can fix it in a second PR, the test is passing

@traversaro
Copy link
Member

@traversaro these changes seem consistent to you?

They seems fine!

@traversaro traversaro mentioned this pull request Aug 31, 2023
Closed
@traversaro
Copy link
Member

@traversaro these changes seem consistent to you?

They seems fine!

Actually I only checked the changes in the transform of the FT sensor in the sole, and I overlooked the other changes and the additional links that were added by this PR, that are fishy ndeed, see #165 .

@Nicogene
Copy link
Member

Nicogene commented Sep 1, 2023

@traversaro these changes seem consistent to you?

They seems fine!

Actually I only checked the changes in the transform of the FT sensor in the sole, and I overlooked the other changes and the additional links that were added by this PR, that are fishy ndeed, see #165 .

The other changes are for exporting the frames of the ft sensors, I forgot to change the names in the remappers, but this is fixed by
#162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nicogene Nicogene Nicogene approved these changes

@traversaro traversaro Awaiting requested review from traversaro

Assignees

@Nicogene Nicogene

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nicogene @traversaro