Debian uses systemd not upstart

[micah]

On Debian, the knot package uses systemd unit files. However in the icann-dns/puppet-knot module you are using upstart methods for making sure that knot is running properly:

  if $::kernel == 'Linux' {
    file{'/etc/init/knot.conf':
      ensure  => present,
      content => template('knot/etc/init/knot.conf.erb'),
      require => Package[$package_name],
      notify  => Service[$service_name];
    }

Debian 7 had some support for upstart, but it never fully did, it would be better to use systemd for this, at least in Debian. In fact Ondřej Surý wrote on the knot list this very fact: https://lists.nic.cz/pipermail/knot-dns-users/2014-July/000483.html

It would be simple to just stop shipping this upstart config, and switch the knot::params:: $restart_cmd to be:

$restart_cmd = "${knotc_bin} reload || ${knotc_bin} ${knotc_arg} && systemctl restart knot"