Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: could we make the help window configurable? #1638

Open
1 task done
Bekaboo opened this issue Dec 24, 2024 · 2 comments · May be fixed by #1643
Open
1 task done

Feature: could we make the help window configurable? #1638

Bekaboo opened this issue Dec 24, 2024 · 2 comments · May be fixed by #1643
Labels
feature request New feature

Comments

@Bekaboo
Copy link
Contributor

Bekaboo commented Dec 24, 2024 •
edited
Loading

Have you RTFM'd?

  • I have done proper research

Feature Request

Currently, the help window is hard-coded to open at the bottom of the screen, which can overlap with the fzf window when using split layout:

Before opening help:
image

After opening help:
image

If putting at top with border = "single":

image

Could we expose an option help_winopts that accepts a table as the parameter passed to vim.api.nvim_open_win() so user can customize the border and position of the help window? I am glad to submit a PR for it.
@Bekaboo Bekaboo added the feature request New feature label Dec 24, 2024
@ibhagwan
Copy link
Owner

Could we expose an option help_winopts that accepts a table as the parameter passed to vim.api.nvim_open_win() so user can customize the border and position of the help window? I am glad to submit a PR for it.

Im thinking maybe it’s better to supply a help_open_win opt, the option will be a function responsible for opening a new window, you can then set whatever options you want in nvim_open_win or even open in a top split using vim.cmd(…)?

This would also simplify the config (one single opt) as I don’t foresee too many users customizing the help window.

@Bekaboo
Copy link
Contributor Author

Bekaboo commented Dec 25, 2024

Im thinking maybe it’s better to supply a help_open_win opt, the option will be a function responsible for opening a new window, you can then set whatever options you want in nvim_open_win or even open in a top split using vim.cmd(…)?

Sounds great, thanks!

@Bekaboo Bekaboo linked a pull request Dec 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(help): add option help_open_win to customize help window Bekaboo/fzf-lua
2 participants
@ibhagwan @Bekaboo