Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ibexa/experience] Explicitly declared Gregwar\CaptchaBundle in bundles list #113

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Mar 25, 2024

🎫 Issue IBX-7785

Related PRs:

  • ibexa/personalization#327
  • ibexa/dashboard#114
  • ibexa/product-catalog#1143

Description:

Seems in some cases, like an upgrade from 4.5.6 to 4.6.2 (executed on the installed version from the tag, not x-dev), since Gregwar\CaptchaBundle in not explicitly listed in our bundles manifest, its placement in the bundles list is arbitrary (I'm guessing from some generic Symfony bundles recipe). It needs to be placed after Twig Bundle, because it relies directly on a parameter declared by Twig extension.

$ php bin/console cache:clear

In ParameterBag.php line 93:
                                                                      
  You have requested a non-existent parameter "twig.form.resources".

We require anyway that bundle in the Product, so maybe there's nothing wrong with declaring it explicitly?

$ composer why gregwar/captcha-bundle
ibexa/form-builder v4.6.2 requires  gregwar/captcha-bundle (^2.1)  
ibexa/headless     v4.6.2 requires  gregwar/captcha-bundle (^2.1)

TODO

  • See if this actually works // seems there's no change in recipes

Copy link

Thanks for contribution! 🎉

To test the changes please execute:

composer config extra.symfony.endpoint https://api.github.com/repos/ibexa/recipes-dev/contents/index.json?ref=flex/pull-113

before executing the recipes.

@alongosz alongosz changed the title [ibexa/experience] Explicitly declared Gregwar\CaptchaBundle in bundl… [ibexa/experience] Explicitly declared Gregwar\CaptchaBundle in bundles list Mar 25, 2024
Copy link

sonarcloud bot commented Mar 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants