Fixed PHP deprecated error for $exp overflow for the last language

ibexa · Nov 18, 2024 · afce143 · afce143
1 parent cf6b948
commit afce143
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/lib/Persistence/Legacy/Content/Language/MaskGenerator.php b/src/lib/Persistence/Legacy/Content/Language/MaskGenerator.php
@@ -150,7 +150,8 @@ public function extractLanguageIdsFromMask($languageMask): array
         $result = [];
 
         // Decomposition of $languageMask into its binary components.
-        while ($exp <= $languageMask) {
+        // check if $exp has not overflown and became float (happens for the last possible language in the mask)
+        while (is_int($exp) && $exp <= $languageMask) {
             if ($languageMask & $exp) {
                 $result[] = $exp;
             }

diff --git a/src/lib/Persistence/Legacy/Content/Mapper.php b/src/lib/Persistence/Legacy/Content/Mapper.php
@@ -535,7 +535,8 @@ private function extractLanguageCodesFromMask(int $languageMask, array $allLangu
         $result = [];
 
         // Decomposition of $languageMask into its binary components to extract language codes
-        while ($exp <= $languageMask) {
+        // check if $exp has not overflown and became float (happens for the last possible language in the mask)
+        while (is_int($exp) && $exp <= $languageMask) {
             if ($languageMask & $exp) {
                 if (isset($allLanguages[$exp])) {
                     $result[] = $allLanguages[$exp]->languageCode;