Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename clipDepth to nearClipDepth or similar? #90

Open
ianmackenzie opened this issue Oct 1, 2020 · 2 comments
Open

Rename clipDepth to nearClipDepth or similar? #90

ianmackenzie opened this issue Oct 1, 2020 · 2 comments
Assignees
@ianmackenzie
Labels
breaking change

Comments

@ianmackenzie
Copy link
Owner

As pointed out by @MartinSStewart, the current naming does not make it immediately obvious that it's a near clip depth as opposed to a far clip depth. Possible options:

  • nearClipDepth
  • nearClipDistance
  • minClipDepth
  • minClipDistance
@ianmackenzie ianmackenzie self-assigned this Oct 1, 2020
@MartinSStewart
Copy link

Maybe the term clip could be dropped since it feels like a more technical term and this package has a more high level focus on rendering? minRenderDistance instead perhaps?

@ianmackenzie
Copy link
Owner Author

Ooh I like minRenderDistance! I think that might be my new favourite...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ianmackenzie ianmackenzie

Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ianmackenzie @MartinSStewart