Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use_diurnal_profile=TRUE not working #1

Open
sirpudika opened this issue Nov 29, 2023 · 1 comment
Open

use_diurnal_profile=TRUE not working #1

sirpudika opened this issue Nov 29, 2023 · 1 comment

Comments

@sirpudika
Copy link

sirpudika commented Nov 29, 2023

Hello there!
Thanks for providing this code.
For me, use_diurnal_profile=TRUE does not work. It does not adjust the data within the days. I think that this error originates from the fact that the hour of the weather data is dropped in read_ninja_weather. I would suggest the following change which solves the issue for me:

csv$time = as.POSIXct(csv$time, format="%Y-%m-%d %H:%M")

Cheers, Jan

@sirpudika
Copy link
Author

I had some time zone issues when reading the weather data. I would suggest using:
csv$time = as.POSIXct(csv$time, tz="GMT", format="%Y-%m-%d %H:%M")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant