Incorrect Number of Edge Crosses for edges with Bendpoints

[MobiZaman]

While detecting edge crossings, the code does not consider if the edge is composed of multiple segments, hence finding the intersection of the straight line from source to target with other nodes.

[MobiZaman]

An example figure is given below:

For the above graph, the following properties are determined:

This shows an incorrect number of edge crossings (which in actual are 5). The fact that the code is using a straight line from source to target can be confirmed by converting the edges with bends to straight edges.

The above figure confirms the number of edge crossings to be 3.

[MobiZaman]

As seen by the graph properties in the previous comment, the number of NodeEdgeOverlaps is also shown to be 1, even though there is no node-edge overlap. Here is another example of incorrect values:

[ugurdogrusoz]

@canbax Let's please add a parameter if needed to consider bend points in calculations of metrics involving edges. Particularly we at least need this for orthogonal edges (edges with horizontal and vertical line segments only). Notice that edge ends might have connection points / ports different from clipping points going into a node's center.

[canbax]

I didn't add any new parameters. It will check if there are segment points and then it should calculate accordingly

[ugurdogrusoz]

@MobiZaman Please verify

[MobiZaman]

The edge crosses still don't seem to be determined correctly. For the above drawing, there exist 6 edge crossings, but 1 is not detected by layvo.

[ugurdogrusoz]

Can you attach the json file for easy debugging?

[MobiZaman]

The edge styling data is also needed to create the bendpoints, so only the json file won't be useful. The bug can be reproduced as follows:

1. Go to https://rangmehal.pk/ on Chrome or Firefox
2. Click on the Load graph button and load this graph:
   samplejson.txt
   @canbax This is the same json file that I sent to you before.
3. Do the C-TSM layout 4 times.
4. At the fourth run, check the results of this command: cy.layvo("get").generalProperties();. It will give an incorrect value of edge crossings.

Note: Please disregard the values of the parameters displayed on the top of the page. They are incorrect. The correct values can be checked with (cy.layvo("get").generalProperties()) after the layout has finished.

[MobiZaman]

The code seems to be working fine for now. I will confirm this on multiple graphs and then close this issue.