Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlights or annotations are not visible in Telegra.ph #1413

Open
OnkelTem opened this issue Nov 21, 2023 · 6 comments
Open

Highlights or annotations are not visible in Telegra.ph #1413

OnkelTem opened this issue Nov 21, 2023 · 6 comments

Comments

@OnkelTem
Copy link

After a highlight is created, it disappears from the page.

Example:

2023-11-21_18-45

Source:

https://telegra.ph/Strategy--Society---The-Link-Between-Competitive-Advantage-and-Corporate-Social-Responsibility-2006-11-21

I guess any telegra.ph article will be like that.

@robertknight
Copy link
Member

It looks like this page includes some version of Quill on it. Whenever Hypothesis tries to insert a highlight on the page, the paragraph gets "sanitized" and only certain elements are retained afterwards (eg. <b> is allowed but <mark> is not).

@OnkelTem
Copy link
Author

@robertknight Thanks for the analysis. Do you have any ideas on how to work this out?

@robertknight
Copy link
Member

In short, you need to get a copy of the page without JavaScript. The dumbest solution is to print/export the page to a PDF and annotate that. Ideally we'd have a built-in way to do this with Hypothesis.

@OnkelTem
Copy link
Author

OnkelTem commented Nov 22, 2023

In short, you need to get a copy of the page without JavaScript. The dumbest solution is to print/export the page to a PDF and annotate that. Ideally we'd have a built-in way to do this with Hypothesis.

Well, under solution I didn't mean solving my issue in particular. Instead, I was thinking about a way to get it working on telegra.ph by fixing something in Hypothesis. I think it might be important because it's a publication platform used by many.

Speaking of my specific situation and PDF. A funny thing is that a PDF - is what I had initially, but Hypothesis didn't want to work with it. I don't remember the precise error message tho, maybe it was due to its local path. So I spent an hour copy-pasting the article, paragraph after paragraph to this telegraph publication. To finally discover that Hypothesis won't work. Meh. Unlucky me.

Let me check if I can use a local PDF one more time.

@OnkelTem
Copy link
Author

Nevermind, I should have read the message, haha. It clearly says I should have clicked this nice link: https://web.hypothes.is/help/annotating-locally-saved-pdfs/#2-change-your-settings-in-chrome-if-applicable

@OnkelTem
Copy link
Author

Still, I think it would be great to get Hypothesis working in all telegra.ph pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants