Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Never asked for camera permissions if photo permissions are given. #141

Closed
onato opened this issue Feb 26, 2019 · 1 comment
Closed

Never asked for camera permissions if photo permissions are given. #141

onato opened this issue Feb 26, 2019 · 1 comment

Comments

@onato
Copy link

onato commented Feb 26, 2019

If you have previously given access to the photos, but not to the camera, Gallery never asks for permission to access the camera. Before adopting Gallery, the app may not have used the camera and never asked for permissions for it and only asked for permission to access photos.

Gallery/Sources/Gallery/GalleryController.swift

Lines 70 to 73 in 11183c1

func makePagesController() -> PagesController? {
guard Permission.Photos.status == .authorized else {
return nil
}

Possibly related: #79.
onato added a commit to onato/Gallery that referenced this issue Feb 26, 2019
@onato
Make sure the permissions controller is displayed if the camera permi…
b825cae 
…ssions are not determined. hyperoslo#141
@onato onato mentioned this issue Feb 26, 2019
Open
onato added a commit to onato/Gallery that referenced this issue Feb 26, 2019
@onato
Make sure the permissions controller is displayed if the camera permi…
b80b0dc 
…ssions are not determined. hyperoslo#141
onato added a commit to onato/Gallery that referenced this issue Feb 26, 2019
@onato
Make sure the permissions controller is displayed if the camera permi…
8787b2a 
…ssions are not determined. hyperoslo#141
onato added a commit to onato/Gallery that referenced this issue Feb 26, 2019
@onato
Make sure the permissions controller is displayed if the camera permi…
338e88a 
…ssions are not determined. hyperoslo#141
@onato
Copy link
Author

onato commented Apr 3, 2019 •
edited
Loading

Can someone take a look at my PR to fix this? #142

@3lvis 3lvis closed this as completed Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@onato @3lvis