Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(agent): define the OAS for CredentialIssuerEndpoints [WIP] #909

Closed
wants to merge 42 commits into from
Closed

feat(agent): define the OAS for CredentialIssuerEndpoints [WIP] #909

wants to merge 42 commits into from

Conversation

yshyn-iohk
Copy link
Member

Description:

The Credential Issuance OIDC endpoint MVP is implemented in the Agent. ATL-6518

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@yshyn-iohk yshyn-iohk marked this pull request as draft February 28, 2024 15:00
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 28, 2024 •
edited
Loading

Integration Test Results

15 files  ±0  15 suites  ±0   2s ⏱️ ±0s
33 tests ±0  33 ✅ ±0  0 💤 ±0  0 ❌ ±0 
42 runs  ±0  42 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit a639d94. ± Comparison against base commit 3608aaf.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 28, 2024 •
edited
Loading

Unit Test Results

 96 files  + 3   96 suites  +3   21m 2s ⏱️ +58s
823 tests +32  814 ✅ +31  8 💤 ±0  1 ❌ +1 
830 runs  +32  821 ✅ +31  8 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit a639d94. ± Comparison against base commit 3608aaf.

♻️ This comment has been updated with latest results.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarCloud

yshyn-iohk and others added 17 commits April 30, 2024 12:27
@yshyn-iohk
feat(agent): define the OAS for CredentialIssuerEndpoints
c35103b 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
feat(agent): implement Nonce stub endpoint for OIDC credential issuer
c983d4c 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
feat(agent): add CredentialIssuerService mock and get walletId by pri…
276865f 
…sm DID method

Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
feat(agent): implement the VC issuance flow with the dummy data
347fe55 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk
feat(agent): implement the VC issuance flow with the dummy data
d387df2 
Signed-off-by: Yurii Shynbuiev <[email protected]>
feat: credential offer endpoint and keycloak plugin wip (#935)
a7919fe 
Signed-off-by: Pat Losoponkul <[email protected]>
@yshyn-iohk
feat(agent): add IssuanceSession and NonceService
e648e25 
Signed-off-by: Yurii Shynbuiev <[email protected]>
docs: add example instruction how to run
104731b
fix: integrate oidc4vc CredentialOffer to IssuanceSession (#943)
a6c4a25
@yshyn-iohk
doc(agent): add the details to the readme.md and change the port of t…
16d11bd 
…he mock server

Signed-off-by: Yurii Shynbuiev <[email protected]>
chore: resolve rebase conflict
6a83797
chore: resolve rebase conflict
441d474
chore: resolve merge compilation conflict
ec586be
@womfoo
feat: oidc4vc issuer metadata and credential configuration CRUD (#977)
c5de8f2 
Signed-off-by: Kranium Gikos Mendoza <[email protected]>
Co-authored-by: womfoo <[email protected]>
test: fix test layer make it pass
d2b462b
chore: resolve rename conflicts
9085dca
chore: resolve rename conflicts
a91b8e7
@coveralls
Copy link

coveralls commented May 6, 2024 •
edited
Loading

Coverage Status

coverage: 48.009% (-1.4%) from 49.381%
when pulling c30a244 on oidc
into 3438438 on main.

Pat Losoponkul and others added 15 commits May 23, 2024 18:15
Merge branch 'main' into oidc
160d451 
Signed-off-by: Pat Losoponkul <[email protected]>
fix: integrate issuer metadata in oid4vci credential endpoint (#1105)
4eda59a 
Signed-off-by: Pat Losoponkul <[email protected]>
ci: fix linter warnings (#1109)
0eff8cb 
Signed-off-by: Pat Losoponkul <[email protected]>
Merge branch 'main' into oidc
ce577fd
Resolve merge conflicts
5e34d91
fix: re-number migration
94fa370
Merge branch 'main' into oidc
f22f1e8
fix: make oidc local script work (#1131)
a639d94 
Signed-off-by: Pat Losoponkul <[email protected]>
feat: authentication for oid4vci credential and nonce endpoint (#1148)
1c6fd95 
Signed-off-by: Pat Losoponkul <[email protected]>
fix: update issuer auth server model parity (#1154)
096b746 
Signed-off-by: Pat Losoponkul <[email protected]>
@yshyn-iohk @github-actions @hyperledger-bot
feat(agent): validate JWT proof in the credential request, update dem… (
22883c7 
#1165)

Signed-off-by: Yurii Shynbuiev <[email protected]>
Signed-off-by: Hyperledger Bot <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Hyperledger Bot <[email protected]>
@yshyn-iohk
feat: add claims to the VC (#1176)
a692122 
Signed-off-by: Yurii Shynbuiev <[email protected]>
chore: migrate oid4vci example to published keycloak plugin (#1174)
28c30ba 
Signed-off-by: Pat Losoponkul <[email protected]>
fix: add claims validation when creating oid4vci credential offer (#1178
da190a3 
)

Signed-off-by: Pat Losoponkul <[email protected]>
@yshyn-iohk
feat: use kid in the jwt proof header of OID4VCI CredentialIssue request
1818686 
Signed-off-by: Yurii Shynbuiev <[email protected]>
@yshyn-iohk yshyn-iohk closed this Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvoiturier bvoiturier Awaiting requested review from bvoiturier

@patlo-iog patlo-iog Awaiting requested review from patlo-iog

Assignees
No one assigned
Labels
build castor ci cloud-agent docs infra mercury pollux prism-agent shared
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yshyn-iohk @coveralls @atala-dev