Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: reorganise apollo and remove unused modules #106

Merged
merged 8 commits into from
Nov 13, 2023
Merged

build: reorganise apollo and remove unused modules #106

merged 8 commits into from
Nov 13, 2023

Conversation

goncalo-frade-iohk
Copy link
Contributor

No description provided.

@atala-dev
Copy link
Contributor

atala-dev commented Oct 31, 2023 •
edited
Loading

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 1 0 0.19s
✅ EDITORCONFIG editorconfig-checker 134 0 0.4s
✅ KOTLIN ktlint 128 0 270.94s
⚠️ REPOSITORY devskim yes 36 3.94s
✅ REPOSITORY dustilock yes no 0.06s
✅ REPOSITORY gitleaks yes no 2.29s
✅ REPOSITORY git_diff yes no 0.03s
✅ REPOSITORY grype yes no 16.27s
⚠️ REPOSITORY kics yes 1 56.59s
✅ REPOSITORY secretlint yes no 2.89s
✅ REPOSITORY syft yes no 0.37s
✅ REPOSITORY trivy yes no 7.88s
✅ REPOSITORY trivy-sbom yes no 1.52s
⚠️ REPOSITORY trufflehog yes 1 6.09s
✅ XML xmllint 1 0 0.01s
⚠️ YAML prettier 1 1 0.71s
✅ YAML v8r 1 0 2.54s
✅ YAML yamllint 1 0 0.48s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/ATL-6096 branch 3 times, most recently from 3efad1c to a8e8848 Compare October 31, 2023 10:56
@atala-dev
Copy link
Contributor

atala-dev commented Oct 31, 2023 •
edited
Loading

Code Coverage

File Coverage [89.32%] ❌
cryptography/src/androidMain/kotlin/io/iohk/atala/prism/apollo/derivation/Mnemonic.kt 0.00% ❌
cryptography/src/androidMain/kotlin/io/iohk/atala/prism/apollo/derivation/MnemonicCode.kt 0.00% ❌
cryptography/src/androidMain/kotlin/io/iohk/atala/prism/apollo/secp256k1/Secp256k1Lib.kt 92.31% ✅
cryptography/src/androidMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdKeyPair.kt 100.00% ✅
cryptography/src/androidMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdPrivateKey.kt 66.67% ❌
cryptography/src/androidMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdPublicKey.kt 77.78% ❌
cryptography/src/androidMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMRSAKeyPair.kt 0.00% ❌
cryptography/src/androidMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMRSAPrivateKey.kt 0.00% ❌
cryptography/src/androidMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMRSAPublicKey.kt 0.00% ❌
cryptography/src/androidMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMX25519KeyPair.kt 100.00% ✅
cryptography/src/androidMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMX25519PrivateKey.kt 25.00% ❌
cryptography/src/androidMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMX25519PublicKey.kt 100.00% ✅
cryptography/src/androidMain/kotlin/io/iohk/atala/prism/apollo/utils/RSAAsymmetricAlgorithm.kt 0.00% ❌
cryptography/src/commonMain/kotlin/io/iohk/atala/prism/apollo/derivation/DerivationAxis.kt 0.00% ❌
cryptography/src/commonMain/kotlin/io/iohk/atala/prism/apollo/derivation/DerivationPath.kt 0.00% ❌
cryptography/src/commonMain/kotlin/io/iohk/atala/prism/apollo/derivation/HDKey.kt 70.79% ❌
cryptography/src/commonMain/kotlin/io/iohk/atala/prism/apollo/derivation/HDKeyOptions.kt 100.00% ✅
cryptography/src/commonMain/kotlin/io/iohk/atala/prism/apollo/derivation/MnemonicCodeEnglish.kt 100.00% ✅
cryptography/src/commonMain/kotlin/io/iohk/atala/prism/apollo/derivation/MnemonicException.kt 0.00% ❌
cryptography/src/commonMain/kotlin/io/iohk/atala/prism/apollo/derivation/MnemonicHelper.kt 90.48% ✅
cryptography/src/commonMain/kotlin/io/iohk/atala/prism/apollo/secp256k1/Secp256k1Lib.kt 92.31% ✅
cryptography/src/commonMain/kotlin/io/iohk/atala/prism/apollo/utils/ECConfig.kt 100.00% ✅
cryptography/src/commonMain/kotlin/io/iohk/atala/prism/apollo/utils/ECKeyExceptions.kt 0.00% ❌
cryptography/src/commonMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMECPoint.kt 18.18% ❌
cryptography/src/commonMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMECSecp256k1PrivateKey.kt 86.67% ❌
cryptography/src/commonMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMECSecp256k1PublicKey.kt 56.67% ❌
cryptography/src/commonMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdKeyPair.kt 100.00% ✅
cryptography/src/commonMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdPrivateKey.kt 66.67% ❌
cryptography/src/commonMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdPublicKey.kt 77.78% ❌
cryptography/src/commonMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEllipticCurve.kt 0.00% ❌
cryptography/src/commonMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMRSAKeyPair.kt 0.00% ❌
cryptography/src/commonMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMRSAPrivateKey.kt 0.00% ❌
cryptography/src/commonMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMRSAPublicKey.kt 0.00% ❌
cryptography/src/commonMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMX25519KeyPair.kt 100.00% ✅
cryptography/src/commonMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMX25519PrivateKey.kt 25.00% ❌
cryptography/src/commonMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMX25519PublicKey.kt 100.00% ✅
cryptography/src/commonMain/kotlin/io/iohk/atala/prism/apollo/utils/RSAAsymmetricAlgorithm.kt 0.00% ❌
cryptography/src/commonMain/kotlin/io/iohk/atala/prism/apollo/utils/bip39/MnemonicException.kt 0.00% ❌
cryptography/src/iosMain/kotlin/io/iohk/atala/prism/apollo/derivation/Mnemonic.kt 0.00% ❌
cryptography/src/iosMain/kotlin/io/iohk/atala/prism/apollo/derivation/MnemonicCode.kt 0.00% ❌
cryptography/src/iosMain/kotlin/io/iohk/atala/prism/apollo/secp256k1/Secp256k1Lib.kt 92.31% ✅
cryptography/src/iosMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdKeyPair.kt 100.00% ✅
cryptography/src/iosMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdPrivateKey.kt 66.67% ❌
cryptography/src/iosMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdPublicKey.kt 77.78% ❌
cryptography/src/iosMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMRSAKeyPair.kt 0.00% ❌
cryptography/src/iosMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMRSAPrivateKey.kt 0.00% ❌
cryptography/src/iosMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMRSAPublicKey.kt 0.00% ❌
cryptography/src/iosMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMX25519KeyPair.kt 100.00% ✅
cryptography/src/iosMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMX25519PrivateKey.kt 25.00% ❌
cryptography/src/iosMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMX25519PublicKey.kt 100.00% ✅
cryptography/src/iosMain/kotlin/io/iohk/atala/prism/apollo/utils/RSAAsymmetricAlgorithm.kt 0.00% ❌
cryptography/src/jsMain/kotlin/io/iohk/atala/prism/apollo/derivation/Mnemonic.kt 0.00% ❌
cryptography/src/jsMain/kotlin/io/iohk/atala/prism/apollo/derivation/MnemonicCode.kt 0.00% ❌
cryptography/src/jsMain/kotlin/io/iohk/atala/prism/apollo/secp256k1/Secp256k1Lib.kt 92.31% ✅
cryptography/src/jsMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdKeyPair.kt 100.00% ✅
cryptography/src/jsMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdPrivateKey.kt 66.67% ❌
cryptography/src/jsMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdPublicKey.kt 77.78% ❌
cryptography/src/jsMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMRSAKeyPair.kt 0.00% ❌
cryptography/src/jsMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMRSAPrivateKey.kt 0.00% ❌
cryptography/src/jsMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMRSAPublicKey.kt 0.00% ❌
cryptography/src/jsMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMX25519KeyPair.kt 100.00% ✅
cryptography/src/jsMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMX25519PrivateKey.kt 25.00% ❌
cryptography/src/jsMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMX25519PublicKey.kt 100.00% ✅
cryptography/src/jsMain/kotlin/io/iohk/atala/prism/apollo/utils/RSAAsymmetricAlgorithm.kt 0.00% ❌
cryptography/src/jvmMain/kotlin/io/iohk/atala/prism/apollo/derivation/Mnemonic.kt 0.00% ❌
cryptography/src/jvmMain/kotlin/io/iohk/atala/prism/apollo/derivation/MnemonicCode.kt 0.00% ❌
cryptography/src/jvmMain/kotlin/io/iohk/atala/prism/apollo/secp256k1/Secp256k1Lib.kt 92.31% ✅
cryptography/src/jvmMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdKeyPair.kt 100.00% ✅
cryptography/src/jvmMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdPrivateKey.kt 66.67% ❌
cryptography/src/jvmMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMEdPublicKey.kt 77.78% ❌
cryptography/src/jvmMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMRSAKeyPair.kt 0.00% ❌
cryptography/src/jvmMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMRSAPrivateKey.kt 0.00% ❌
cryptography/src/jvmMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMRSAPublicKey.kt 0.00% ❌
cryptography/src/jvmMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMX25519KeyPair.kt 100.00% ✅
cryptography/src/jvmMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMX25519PrivateKey.kt 25.00% ❌
cryptography/src/jvmMain/kotlin/io/iohk/atala/prism/apollo/utils/KMMX25519PublicKey.kt 100.00% ✅
cryptography/src/jvmMain/kotlin/io/iohk/atala/prism/apollo/utils/RSAAsymmetricAlgorithm.kt 0.00% ❌
secp256k1-kmp/src/commonMain/kotlin/fr/acinq/secp256k1/Secp256k1.kt 43.75% ❌
Total Project Coverage 91.19% ✅

@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/ATL-6096 branch 9 times, most recently from 6e836ce to 8979a08 Compare November 8, 2023 18:16
Anton Baliasnikov and others added 7 commits November 10, 2023 15:29
release: add semantic release support
eb034d6
fix: add empty changelog
db7ebee
fix: test apollo release
8fd52ff
@atala-dev
chore(release): cut apollo version 1.0.0-snapshot.1
31ab5ba 
# 1.0.0-snapshot.1 (2023-11-10)

### Bug Fixes

* Add all the required dependencies for Apollo to build with the native cinterops ios version of secp256k1 ec. ([1ca5b68](1ca5b68))
* add empty changelog ([db7ebee](db7ebee))
* add new line at end of file ([a6ab13c](a6ab13c))
* add new line to build.gradle.kts files ([f84b4e4](f84b4e4))
* BigInteger has no corresponding exportable dataType in JS ([#88](#88)) ([3e636be](3e636be))
* bugs found while integrating apollo with KMP SDK ([#98](#98)) ([de71265](de71265))
* CI nonsense error ([1963ad2](1963ad2))
* ci reported linting issues ([31aee01](31aee01))
* ci wrong reported issues by mega lint ([b6da47a](b6da47a))
* **CI:** Update GitHub Actions script ([#90](#90)) ([e6f6d46](e6f6d46))
* code linting ([94ededd](94ededd))
* code linting errors ([69dfbd1](69dfbd1))
* code linting errors ([9774cbc](9774cbc))
* constructor and access to some methods were missing in ios ([#93](#93)) ([a64d707](a64d707))
* deployment script ([#101](#101)) ([6435bf8](6435bf8))
* disable JS on windows platform ([6a2bfd4](6a2bfd4))
* enforce code format ([39f4474](39f4474))
* enforce code format ([9e946fc](9e946fc))
* enforce code format ([f034d69](f034d69))
* enforce code quality ([3b060dd](3b060dd))
* fix deployment CI script ([4583b2f](4583b2f))
* fix error in git ([85d1965](85d1965))
* fix for issue [#30](#30) ([b1c1a4e](b1c1a4e))
* fix group id ([4a70cd6](4a70cd6))
* fixed wrong import in UUID ([622187b](622187b))
* gradle build script ([b191baa](b191baa))
* HMAC for JS platform ([6ce142c](6ce142c))
* iOS import was removed by mistake ([9994889](9994889))
* js module name ([06e4310](06e4310))
* KMP Gradle bug ([#99](#99)) ([648bcdd](648bcdd))
* linting issue ([7918146](7918146))
* Publish npm package ([#103](#103)) ([81ac735](81ac735))
* **secp256k1:** Exposing EC Secp256K1 ([#89](#89)) ([90a578a](90a578a))
* suppress not needed warnings ([0b800c8](0b800c8))
* test apollo release ([8fd52ff](8fd52ff))

### Features

* add mnemonic validation ([#94](#94)) ([173ad94](173ad94))
* add test dependency ([a6b7b25](a6b7b25))
* add UnsupportedOperationException ([852644d](852644d))
* AES & fixes ([d60cafb](d60cafb))
* AES encryption & decryption ([e4af9ec](e4af9ec))
* Apollo to support all apple devices ([b4c22ed](b4c22ed))
* Apollo to support all apple devices ([355970f](355970f))
* Apollo to support all apple devices ([de6fd03](de6fd03))
* **BAE:** updating jsMain Ed25519 keys for use in TS ([#92](#92)) ([c7d3bc1](c7d3bc1))
* base symmetric key encryption module ([b7fb2a3](b7fb2a3))
* Base16 encoding & decoding ([a6be3b8](a6be3b8))
* Base16 Upper ([85fbbef](85fbbef))
* Base32 ([c0ff1f7](c0ff1f7))
* Base58 ([e4c9602](e4c9602))
* base64 ([f1ddaa3](f1ddaa3))
* base64 module init ([f3311a0](f3311a0))
* **bip32:** add hd derivation for jvm/android, ios/macos and js ([#84](#84)) ([d564507](d564507))
* **bip39:** Add Bip39 implementation for all platforms ([#78](#78)) ([b695878](b695878))
* char ext ([8a68df1](8a68df1))
* compress and uncompress secp256k1 functionality for (macos,ios,js,android,jvm) ([#95](#95)) ([21c33e4](21c33e4))
* Ed25519 ([eb7f52a](eb7f52a))
* **ed25519:** add jvm and android ed25519 implementation ([#85](#85)) ([ee9757d](ee9757d))
* **ED25519:** ED25519 jsMain implementation ([#76](#76)) ([e8945df](e8945df))
* **ed25519:** ios, macos implementation of ed25519 ([#79](#79)) ([a25798c](a25798c))
* **Experience:** add data type helper methods ([c52cd79](c52cd79))
* **Experience:** add transfer between iOS & KMM ([55ccca5](55ccca5))
* **Experience:** platform os ([208a04f](208a04f))
* **Hashing:** add HashingBase for MD and SHA(1,2) ([859b62a](859b62a))
* **Hashing:** add MathHelper ([2e40af9](2e40af9))
* **Hashing:** BLAKE-family Unit tests ([f414634](f414634))
* **Hashing:** BLAKE224 ([f2d658e](f2d658e))
* **Hashing:** BLAKE256 ([0b02aef](0b02aef))
* **Hashing:** BLAKE2B ([a6ed518](a6ed518))
* **Hashing:** BLAKE2B Unit tests ([45de7b6](45de7b6))
* **Hashing:** BLAKE2B-160 ([dacbb57](dacbb57))
* **Hashing:** BLAKE2B-256 ([0ed656d](0ed656d))
* **Hashing:** BLAKE2B-384 ([32d8ce6](32d8ce6))
* **Hashing:** BLAKE2B-512 ([f1d5043](f1d5043))
* **Hashing:** BLAKE2S ([50bb741](50bb741))
* **Hashing:** BLAKE2S Unit tests ([1284bb3](1284bb3))
* **Hashing:** BLAKE2S-128 ([fbf9ed2](fbf9ed2))
* **Hashing:** BLAKE2S-160 ([9a6e6a6](9a6e6a6))
* **Hashing:** BLAKE2S-224 ([dad2561](dad2561))
* **Hashing:** BLAKE2S-256 ([d2c0fc8](d2c0fc8))
* **Hashing:** BLAKE384 ([dc42633](dc42633))
* **Hashing:** BLAKE512 ([2a4e1b5](2a4e1b5))
* **Hashing:** digest interface ([4548aa1](4548aa1))
* **Hashing:** KeccakDigest ([a10f5f2](a10f5f2))
* **Hashing:** MD2 ([803fc73](803fc73))
* **Hashing:** MD4 ([859d26a](859d26a))
* **Hashing:** MD5 ([9f57ce5](9f57ce5))
* **Hashing:** SHA0 ([2469d1d](2469d1d))
* **Hashing:** SHA0 Unit tests ([482b3a9](482b3a9))
* **Hashing:** SHA1 ([f33d1d9](f33d1d9))
* **Hashing:** SHA1 Unit Tests ([b83af38](b83af38))
* **Hashing:** SHA224 ([47534f7](47534f7))
* **Hashing:** SHA224 Unit tests ([59d8751](59d8751))
* **Hashing:** SHA256 ([a12af78](a12af78))
* **Hashing:** SHA256 Unit tests ([c829aab](c829aab))
* **Hashing:** SHA3-224 ([372e5a9](372e5a9))
* **Hashing:** SHA3-256 ([a885989](a885989))
* **Hashing:** SHA3-384 ([2fa5b14](2fa5b14))
* **Hashing:** SHA3-512 ([e45543e](e45543e))
* **Hashing:** SHA3-family Unit tests ([ac535d2](ac535d2))
* **Hashing:** SHA384 ([207a58e](207a58e))
* **Hashing:** SHA384 Unit tests ([09ec034](09ec034))
* **Hashing:** SHA512 ([a9d10bf](a9d10bf))
* **Hashing:** SHA512 Unit tests ([c567ff7](c567ff7))
* **Hashing:** SHA512/224 ([192b205](192b205))
* **Hashing:** SHA512/224 Unit test ([62a2ede](62a2ede))
* **Hashing:** SHA512/256 ([6ddd004](6ddd004))
* **Hashing:** SHA512/256 Unit test ([24450a4](24450a4))
* Long ext ([fe5e1cf](fe5e1cf))
* **MAC:** HMAC implementation ([935d9c2](935d9c2))
* **mnemonic:** js doesnt handle List and swift doesnt handle Array this is the solution ([#105](#105)) ([e65e0f0](e65e0f0))
* multibase ([73a1e7b](73a1e7b))
* NumberFormatException ext ([8955561](8955561))
* **secp256k1:** add library to be our dependency for secp256k1 in android, jvm, ios, macos, js ([3e41246](3e41246))
* Secure Random ([e577736](e577736))
* Utils module ([ba7eefb](ba7eefb))
* UUID ([85afcb8](85afcb8))
* UUID init ([a1d9b65](a1d9b65))
* x25519 key pair generation ([4227c2c](4227c2c))
* **x25519:** add x25519 implementation for ios, macos ([#80](#80)) ([c18c0eb](c18c0eb))
fix: npmjs auto packages with gradle plugin
6f9871b
@atala-dev
chore(release): cut apollo version 1.7.0-snapshot.1
1efdd36 
# [1.7.0-snapshot.1](v1.0.0-snapshot.1...v1.7.0-snapshot.1) (2023-11-10)

### Bug Fixes

* npmjs auto packages with gradle plugin ([6f9871b](6f9871b))
fix: correct release version
0f86e83
@antonbaliasnikov antonbaliasnikov merged commit 8fa5db0 into main Nov 13, 2023
2 checks passed
@antonbaliasnikov antonbaliasnikov deleted the feature/ATL-6096 branch November 13, 2023 15:46
hamada147 added a commit that referenced this pull request May 20, 2024
@goncalo-frade-iohk @hamada147
build: reorganise apollo and remove unused modules (#106)
d8498cf 
Co-authored-by: Anton Baliasnikov <[email protected]>
Co-authored-by: Ahmed Moussa <[email protected]>
Signed-off-by: Goncalo Frade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamada147 hamada147 hamada147 approved these changes

@elribonazo elribonazo Awaiting requested review from elribonazo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@goncalo-frade-iohk @atala-dev @hamada147 @antonbaliasnikov