Skip to content
This repository has been archived by the owner on Feb 13, 2024. It is now read-only.

Allow selective disclosure when answering a presentation request #800

Open
etschelp opened this issue Aug 12, 2022 · 2 comments
Open

Allow selective disclosure when answering a presentation request #800

etschelp opened this issue Aug 12, 2022 · 2 comments
Labels
backend frontend presentation-exchange All tasks related to presentation exchanges

Comments

@etschelp
Copy link
Contributor

etschelp commented Aug 12, 2022

Indy:

Currently all attributes are always revealed when answering a presentation request. This could stay as the default option, but it makes sense to have the option (per attribute, or attribute group, depending on the request) not to reveal information, this could be as simple as a checkbox.

Dif:

Same as above but on top we need the option to switch between Ed25519S and bbs+ when issuing credentials and sending the presentation request. Also the dif request needs a different format and the limit disclosure flag in this case.

@etschelp etschelp added frontend backend presentation-exchange All tasks related to presentation exchanges labels Aug 12, 2022
@swcurran
Copy link

Two things on this.

First, we're trying to shift the term "Indy" (as you have used it) to "AnonCreds", as we now have running examples of using AnonCreds verifiable credentials without using Indy -- essentially, ledger-agnostic AnonCreds. Several implementations are pending. We'll be merging a PR into the AnonCreds Specification about that.

Second: We've discovered that ACA-Py is marking as "verification=false" if the prover marks attributes as "unrevealed", which we think is wrong. We're looking at the code in ACA-Py around that to see if there are any other conditions that are flagged where the AnonCreds verification is true (e.g. the cryptography checks out), but that ACA-Py is flagging as failing the verification. This just came up in the last couple of days in this issue. Please weigh in on that issue if you have ideas about how this change should be made.

Thanks!

@etschelp
Copy link
Contributor Author

etschelp commented Aug 24, 2022

break implementation down into four parts:

  • redo be/fe for anoncreds, rest call and UI, add reveal flags
  • add "must reveal" flag to proof template, add handling to be, add UI notification to adjust for changed acapy behavior
  • redo rendering of dif presentation request based on proof template
  • redo handling dif presentation request incoming

etschelp added a commit to boschresearch/business-partner-agent that referenced this issue Sep 9, 2022
hyperledger-labs#801

updated model and helper to allow to send more info from the frontend

Signed-off-by: Philipp Etschel <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend frontend presentation-exchange All tasks related to presentation exchanges
Projects
None yet
Development

No branches or pull requests

2 participants