Skip to content
This repository has been archived by the owner on Feb 13, 2024. It is now read-only.

Feature/vue3 upgrade #783

Closed
wants to merge 21 commits into from
Closed

Feature/vue3 upgrade #783

wants to merge 21 commits into from

Conversation

marcelTUB
Copy link

@marcelTUB marcelTUB commented Jul 20, 2022

Preparations for upgrading vue2 to vue3

  • upgrade vue, vue-cli-service and vue/cli-service plugins

  • use migration build

  • fix compiler warnings (filters, v-bind, key on template tag, template without directives)

  • fix some errors by commenting problematic lines

@DritonGoxhufi DritonGoxhufi linked an issue Jul 20, 2022 that may be closed by this pull request
@schlagtim
Copy link
Contributor

Thanks for your contribution!
It seems like the DCO checks are failing because your commits are not signed off - these commits cannot be merged.
Please read the Contributing document in the root directory, particularly the chapter Sign your work.

Your previous commits (apart from the most recent one) cannot be signed-off anymore. The DCO check will always fail if there is at least one unsigned commit. Possible solutions in this situation are:

  • Rewrite your commits git history with git filter-branch and git interpret-trailers: https://stackoverflow.com/a/15667644
  • Or squash all commits into one commit and sign-off this commit (e.g. with git --amend). Your history (individual commits) will be lost

Whatever solutions you choose, you will probably have to do a force push to overwrite the history here.

To prevent this in the future you usually can activate a "always sign-off commits" option in your IDE (most of them support it) or git tool which I highly recommend.

marcel.ebermann added 19 commits July 25, 2022 16:10
Signed-off-by: marcel.ebermann <[email protected]>
Signed-off-by: marcel.ebermann <[email protected]>
Signed-off-by: marcel.ebermann <[email protected]>
Signed-off-by: marcel.ebermann <[email protected]>
 and COMPILER_V_BIND_SYNC warnings

Signed-off-by: marcel.ebermann <[email protected]>
Signed-off-by: marcel.ebermann <[email protected]>
Signed-off-by: marcel.ebermann <[email protected]>
Signed-off-by: marcel.ebermann <[email protected]>
Signed-off-by: marcel.ebermann <[email protected]>
Signed-off-by: marcel.ebermann <[email protected]>
Signed-off-by: marcel.ebermann <[email protected]>
Signed-off-by: marcel.ebermann <[email protected]>
Signed-off-by: marcel.ebermann <[email protected]>
@etschelp
Copy link
Contributor

We just found out that the support for data tables will be available with vuetify 3.1 see vuetifyjs/vuetify#13479 (comment)

It will probably be a while until this happens, as we rely heavily on data tables, it probably makes sense to do the following:

  • upgrade all plugins
  • do the vue3 upgrade
  • keep the migration build
  • check if the UI keeps running
  • merge

marcel.ebermann added 2 commits August 8, 2022 09:21
Signed-off-by: marcel.ebermann <[email protected]>
Signed-off-by: marcel.ebermann <[email protected]>
@marcelTUB marcelTUB closed this by deleting the head repository Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue 3 upgrade - estimate effort
3 participants