Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move integration tests out of iroha #5168

Open
mversic opened this issue Oct 18, 2024 · 1 comment · May be fixed by #5203
Open

Move integration tests out of iroha #5168

mversic opened this issue Oct 18, 2024 · 1 comment · May be fixed by #5203
Assignees
@mversic

Comments

@mversic
Copy link
Contributor

mversic commented Oct 18, 2024 •
edited
Loading

We should remove integration tests from iroha into a separate crate. The reason is that those are not client integration tests but rather a full system tests. I propose that we move them into iroha_test_network and rename the iroha_test_network into iroha_test_suite or something similar

I would like to get your opinions here
@mversic mversic moved this to Required for MVP in Iroha Oct 18, 2024
@mversic mversic added the question Further information is requested label Oct 18, 2024
@0x009922
Copy link
Contributor

I propose that we move them into iroha_test_network and rename the iroha_test_network into iroha_test_suite or something similar

iroha_test_network might in future replace current test_env.py if we make it an executable. This might be useful e.g. to re-use it in JS SDK tests and in other SDKs too. Renaming it to iroha_test_suite contradicts this intention.

Apart from that, I agree that integration tests are better to be in a separate place from the client.

@mversic mversic self-assigned this Oct 29, 2024
@mversic mversic removed the question Further information is requested label Oct 29, 2024
@mversic mversic linked a pull request Oct 29, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mversic mversic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: move tests to separate repo mversic/iroha
2 participants
@0x009922 @mversic