Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent tests failing if they can't get access to a port #2137

Closed
appetrosyan opened this issue Apr 22, 2022 · 0 comments
Closed

Prevent tests failing if they can't get access to a port #2137

appetrosyan opened this issue Apr 22, 2022 · 0 comments
Assignees
@ales-tsurko
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Tests

Comments

@appetrosyan
Copy link
Contributor

appetrosyan commented Apr 22, 2022 •
edited
Loading

Our current solution of randomly mapping ports at run-time is not the best, because of how it can fail on restricted systems, but also fails to work corretly on e.g. nextest (#2136).

My preferred solution would be to actively handle the OS error and re-assign the port in case of failure, so that random failed port assignments don't bring down the entire test harness.
@appetrosyan appetrosyan added iroha2-dev The re-implementation of a BFT hyperledger in RUST Tests labels Apr 22, 2022
@appetrosyan appetrosyan self-assigned this May 9, 2022
@appetrosyan appetrosyan added the good first issue Good for newcomers label Jun 1, 2022
ales-tsurko added a commit to ales-tsurko/iroha that referenced this issue Jun 7, 2022
@ales-tsurko
[fix] hyperledger-iroha#2137: Fix ports collision in cli tests
e7b5d3f 
Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko added a commit to ales-tsurko/iroha that referenced this issue Jun 7, 2022
@ales-tsurko
[fix] hyperledger-iroha#2137: Fix ports collision in p2p tests
c4e5ea0 
Signed-off-by: Ales Tsurko <[email protected]>
@appetrosyan appetrosyan removed the good first issue Good for newcomers label Jun 9, 2022
ales-tsurko added a commit to ales-tsurko/iroha that referenced this issue Jun 13, 2022
@ales-tsurko
[fix] hyperledger-iroha#2137: Add UniquePortProvider
d262a27 
Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko added a commit to ales-tsurko/iroha that referenced this issue Jun 15, 2022
@ales-tsurko
[fix] hyperledger-iroha#2137: Fix tests for iroha_client
dfdbb33 
Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko added a commit to ales-tsurko/iroha that referenced this issue Jun 15, 2022
@ales-tsurko
[fix] hyperledger-iroha#2137: Fix the rest of the tests (cli, client,…
dd9aac6 
… data_model)

Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko added a commit to ales-tsurko/iroha that referenced this issue Jun 20, 2022
@ales-tsurko
[fix] hyperledger-iroha#2137: Fix tests for iroha_client
f5c3285 
Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko added a commit to ales-tsurko/iroha that referenced this issue Jun 20, 2022
@ales-tsurko
[fix] hyperledger-iroha#2137: Fix the rest of the tests (cli, client,…
567cca7 
… data_model)

Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko added a commit to ales-tsurko/iroha that referenced this issue Jun 22, 2022
@ales-tsurko
[fix] hyperledger-iroha#2137: Fix tests for iroha_client
dc4dcb6 
Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko added a commit to ales-tsurko/iroha that referenced this issue Jun 22, 2022
@ales-tsurko
[fix] hyperledger-iroha#2137: Fix the rest of the tests (cli, client,…
f3da4eb 
… data_model)

Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko added a commit to ales-tsurko/iroha that referenced this issue Jun 22, 2022
@ales-tsurko
[fix] hyperledger-iroha#2137: Refactor with new version of unique_por…
891e532 
…t crate

Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko added a commit to ales-tsurko/iroha that referenced this issue Jun 22, 2022
@ales-tsurko
[fix] hyperledger-iroha#2137: Update unique_port version
7fcad73 
Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko added a commit to ales-tsurko/iroha that referenced this issue Jun 22, 2022
@ales-tsurko
[fix] hyperledger-iroha#2137: Fix tests for iroha_client
6b8ad43 
Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko added a commit to ales-tsurko/iroha that referenced this issue Jun 22, 2022
@ales-tsurko
[fix] hyperledger-iroha#2137: Fix the rest of the tests (cli, client,…
6cbbd1c 
… data_model)

Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko added a commit to ales-tsurko/iroha that referenced this issue Jun 22, 2022
@ales-tsurko
[fix] hyperledger-iroha#2137: Refactor with new version of unique_por…
a47f747 
…t crate

Signed-off-by: Ales Tsurko <[email protected]>
ales-tsurko added a commit to ales-tsurko/iroha that referenced this issue Jun 22, 2022
@ales-tsurko
[fix] hyperledger-iroha#2137: Update unique_port version
0077800 
Signed-off-by: Ales Tsurko <[email protected]>
@ales-tsurko ales-tsurko mentioned this issue Jun 22, 2022
Merged
ales-tsurko added a commit to ales-tsurko/iroha that referenced this issue Jun 24, 2022
@ales-tsurko
[fix] hyperledger-iroha#2137: Update unique_port dependency spec
c3da32e 
Signed-off-by: Ales Tsurko <[email protected]>
appetrosyan pushed a commit that referenced this issue Jun 24, 2022
@ales-tsurko
[fix] #2137: Prepare tests for multiprocess context (#2363)
d9d2d4c
BAStos525 pushed a commit to BAStos525/soramitsu-iroha that referenced this issue Jul 8, 2022
@ales-tsurko @BAStos525
[fix] hyperledger-iroha#2137: Prepare tests for multiprocess context (h…
535164a 
…yperledger-iroha#2363)

Signed-off-by: BAStos525 <[email protected]>
@0x009922 0x009922 mentioned this issue Jul 28, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ales-tsurko ales-tsurko

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ales-tsurko @appetrosyan