Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RecvStream::is_end_stream(): return true only when END_STREAM is received #810

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix RecvStream::is_end_stream(): return true only when END_STREAM is received #810

wants to merge 1 commit into from

Conversation

eaufavor
Copy link
Contributor

@eaufavor eaufavor commented Nov 4, 2024

Before this change, it returned true on other types of disconnection as well.

Fixes #806

Removed unused is_recv_closed().

@eaufavor
Fix RecvStream::is_end_stream(): return true only when END_STREAM is …
1857605 
…received

Before this change, it returned true on other types of disconnection as
well.

Fixes hyperium#806
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RecvStream::is_end_stream() shouldn't return true after encountering error
2 participants
@eaufavor @seanmonstar