RecvStream::is_end_stream() shouldn't return true after encountering error

[eaufavor]

From the doc

Returns true if the receive half has reached the end of stream.
A return value of true means that calls to poll and poll_trailers will both return None.

However in reality, it would return true also after the connection / stream encounters errors because

h2/src/proto/streams/recv.rs

Lines 560 to 562 in 77be664

	if !stream.state.is_recv_closed() {
	return false;
	}

and is_recv_closed is true regardless of the actual cause of the closure

h2/src/proto/streams/state.rs

Lines 416 to 420 in 77be664

	pub fn is_recv_closed(&self) -> bool {
	matches!(
	self.inner,
	Closed(..) | HalfClosedRemote(..) | ReservedLocal
	)

The problem of RecvStream::is_end_stream() returning true after encountering error is that it hints the user that the http request finishes successfully. So incomplete responses might be interpreted as complete ones.

My suggestion is that this function should only return true after seeing END_STREAM flag.

[seanmonstar]

The problem of RecvStream::is_end_stream() returning true after encountering error is that it hints the user that the http request finishes successfully. So incomplete responses might be interpreted as complete ones.

I think you're right. Want to submit a pull request fixing this?

[eaufavor]

Yes will do. Thanks for the confirmation.