Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to build? #155

Open
effigies opened this issue Dec 11, 2024 · 3 comments
Open

Fall back to build? #155

effigies opened this issue Dec 11, 2024 · 3 comments

Comments

@effigies
Copy link

I'm currently hitting astral-sh/uv#5450 with uv build. This reproduces locally and in using build-and-inspect-python-package (see https://github.com/nipreps/smriprep/actions/runs/12284124195):

Package Contents

SDist contents
[2024-12-11T20:12:24Z]  smriprep-0.16.2.dev21+gc83f22d
...
├── [2024-12-11T20:12:24Z]  src
│   └── [2024-12-11T20:12:24Z]  smriprep
│       ├── ...
│       ├── [2024-12-11T20:12:24Z]  data
│       │   ├── [2024-12-11T20:11:55Z]  __init__.py
│       │   ├── [2024-12-11T20:12:24Z]  atlases
│       │   │   ├── ...
│       │   │   ├── [2024-12-11T20:11:55Z]  fsaverage.L_LR.spherical_std.164k_fs_LR.surf.gii
│       │   │   └── [2024-12-11T20:11:55Z]  fsaverage.R_LR.spherical_std.164k_fs_LR.surf.gii
│       │   └── ...
│       └── ...
└── ...

35 directories, 165 files
Wheel contents
smriprep-0.16.2.dev21+gc83f22d
├── smriprep
│   ├── ...
│   ├── data
│   │   ├── __init__.py
│   │   ├── atlases
│   │   │   ├── ...
│   │   │   ├── fsaverage.L_LR.spherical_std.164k_fs_LR.sur
│   │   │   └── fsaverage.R_LR.spherical_std.164k_fs_LR.surf.gii
│   │   └── ...
│   └── ...
└── smriprep-0.16.2.dev21+gc83f22d.dist-info
    ├── METADATA
    ├── RECORD
    ├── WHEEL
    ├── entry_points.txt
    └── licenses
        ├── LICENSE
        └── NOTICE

19 directories, 77 files

If I use pyproject-build, everything looks as it should:

> uvx --from=build pyproject-build --installer uv
> unzip -l dist/smriprep-0.16.2.dev32+g9b20042-py3-none-any.whl | grep atlases.fsaverage.._LR
    22:	  3614784  2020-02-02 00:00   smriprep/data/atlases/fsaverage.L_LR.spherical_std.164k_fs_LR.surf.gii
    23:	  3492005  2020-02-02 00:00   smriprep/data/atlases/fsaverage.R_LR.spherical_std.164k_fs_LR.surf.gii

Would it be possible to add a fallback option to use pyproject-build for cases where bugs are found in uv build?

@hynek hynek changed the title Fall back to pyproject-build? Fall back to build? Dec 12, 2024
@hynek
Copy link
Owner

hynek commented Dec 12, 2024

Hm, we could add an option for choosing your build backend, however I would expect this bug to be fixed soonish – does pinning to 2.8.0 work for you in the meantime?

@effigies
Copy link
Author

Thanks, that worked! Should have checked the changelog...

I'm still moderately for having an option to switch without reverting to an old (and eventually outdated) version, but I recognize that every option is a maintenance burden. So I won't be offended if this gets closed as wontfix.

Thanks for the great tool!

@effigies
Copy link
Author

Just a note that I now need to pin hatchling to 1.26 to avoid generating metadata 2.4, which the twine pinned in the action version 2.8 rejects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants