Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building 2+ packages at once #146

Open
jamesbraza opened this issue Oct 11, 2024 · 3 comments
Open

Building 2+ packages at once #146

jamesbraza opened this issue Oct 11, 2024 · 3 comments

Comments

@jamesbraza
Copy link
Contributor

I have something like this workspace layout, which leads to this GitHub Action:

      - run: |-
          uv build --sdist --wheel --out-dir dist/ .
          uv build --sdist --wheel --out-dir dist/ packages/seeds
          uv build --sdist --wheel --out-dir dist/ packages/bird-feeder

Looking at version 2.9.0's inputs: https://github.com/hynek/build-and-inspect-python-package/blob/v2.9.0/action.yml#L9-L25

Is the correct way to handle this to invoke build-and-inspect-python-package three times, with a different upload-name-suffix each time?

@hynek
Copy link
Owner

hynek commented Oct 12, 2024

Hmm this is virgin soil here. :) I have never used such a setup, so I have to guess a bit, but I would say: cd in to those packages and add a suffix, yes. Please let me know how it goes, so we can add something to the docs.

@jamesbraza
Copy link
Contributor Author

I have something like this:

      - name: Check albatross build
        uses: hynek/build-and-inspect-python-package@v2
        with:
          upload-name-suffix: -albatross
      - name: Check bird-feeder build
        uses: hynek/build-and-inspect-python-package@v2
        with:
          path: packages/bird-feeder
          upload-name-suffix: -bird-feeder
      - name: Check seeds build
        uses: hynek/build-and-inspect-python-package@v2
        with:
          path: packages/seeds
          upload-name-suffix: -seeds

And it leads to this summary:

screenshot of summary

We should put the upload-name-suffix into the summary title, so everything doesn't say Package Contents, it can say Package-albatross Contents (and be distinguishable)

@hynek
Copy link
Owner

hynek commented Dec 15, 2024

It might be also worth to extract the package name from metadata as we do in 2.11 and add “package-name pkg-version” as a header. maybe instead of the generic “Pacakge Contents”. It would require some rejiggering of the job steps tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants