Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIV security key support #25

Open
barde opened this issue Dec 13, 2019 · 8 comments
Open

PIV security key support #25

barde opened this issue Dec 13, 2019 · 8 comments
Labels
enhancement New feature or request

Comments

@barde
Copy link

barde commented Dec 13, 2019

Bug description

According to the readme the Yubikey is supported with PIV keys for SSH login: https://hwsecurity.dev/docs/supported-hardware/

When using TermBot only the OpenGPG key is used, tough.

Steps to reproduce

  1. Add Yubikey
  2. Login to server
  3. Prompt for OpenGPG card is opened
  4. No way to chose PIV key on Yubikey

Expected behavior

When adding a Yubikey or other supported hardware device with PIV support by the SDK a dialogue should offer the user a choice which key system is to be used.

Screenshots

N/A

Android device

  • Device: Samsung S10
  • OS: Android 9
  • TermBot Version: 1.9.5

Server information

  • OS: Debian Buster
  • SSH Software and Version: OpenSSH current
  • Pubkeys used (if applicable): RSA

Additional context

Thanks a lot that finally someone cared for a solution to login with Yubikeys with smart phones! I waited for years and would gladly pay for being able to use the PIV keys with a ssh client.

@barde barde added the bug Something isn't working label Dec 13, 2019
@dschuermann
Copy link
Member

While the SDK does support PIV, Termbot currently only supports OpenPGP. I haven't figured out a good user interface to decide between PIV and OpenPGP...

@dschuermann dschuermann added enhancement New feature or request and removed bug Something isn't working labels Dec 13, 2019
@barde
Copy link
Author

barde commented Dec 15, 2019

Idea: when adding the HSM, Termbot checks if OpenGPG and/or PIV keys are available. If more than one key is found, the user can chose the key he wants to add to this SSH key profile.

The key selection screen shows some general information like key name and location, i.e. OpenGPG/PIV.

@kaisengit
Copy link

Sorry to bother but is there any news on this? It would be super useful to be able to access the keys stored in the PIV interface

@soundspeachy
Copy link

Just want to show additional interest in this request. It would be really great to have PIV support.

@MichalSznajder
Copy link

Having PIV would be great. PIV is much simpler than OpenPGP...

@dschuermann dschuermann changed the title PIV for SSH with Yubikey not working PIV security key support Mar 24, 2021
@xaduha
Copy link

xaduha commented May 19, 2021

IsoApplet is simpler than either of them, basically all you need for SSH auth without cruft.

@sbourdeauducq
Copy link

But it doesn't work with yubikey, does it?

@gaspardle
Copy link

I started to add PIV support, https://github.com/gaspardle/termbot/tree/termbot-piv.

Currently only tested with a Yubikey and an RSA certificate.

Screenshot_TermBot3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants