fix: still dispatch update event if no data present

huww98 · May 13, 2020 · 86946e1 · 86946e1
1 parent 5a13af0
commit 86946e1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/nearestPoint.ts b/src/nearestPoint.ts
@@ -41,6 +41,10 @@ export class NearestPointModel {
         } else {
             const domain = this.model.xScale.invert(this.lastX);
             for (const s of this.options.series) {
+                if (s.data.length == 0) {
+                    this.points.delete(s);
+                    continue;
+                }
                 const pos = domainSearch(s.data, 0, s.data.length, domain, d => d.x);
                 const near: typeof s.data = [];
                 if (pos > 0) {

diff --git a/src/renderModel.ts b/src/renderModel.ts
@@ -52,6 +52,11 @@ export class RenderModel {
     updated = new EventDispatcher();
 
     update() {
+        this.updateModel();
+        this.updated.dispatch();
+    }
+
+    updateModel() {
         for (const s of this.options.series) {
             if (!this.seriesInfo.has(s)) {
                 this.seriesInfo.set(s, {
@@ -104,8 +109,6 @@ export class RenderModel {
                 this.yScale.domain([opYRange.min, opYRange.max])
             }
         }
-
-        this.updated.dispatch();
     }
 
     private redrawRequested = false;