Big refactoring #30
Merged
Big refactoring #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry for a mega-PR, but I've been tinkering with upgrading dependencies and fixing the big-endian problems. In trying to recoup performance, all of these changes got intertwined. At a high level: - Bump all crates to 0.3 to account for breaking changes. - Upgrade to smallvec 1 -- raises the minimum Rust to 1.36. - Various dev-dependencies are upgraded as well. - `primal_bit::BitVec` now stores a `Vec<u8>`, and no longer exposes methods that depend on endianness. Fixes huonw#10. - A lot of the wheel operations were byte-oriented already, so they really depended on little-endian order before. With `Vec<u8>`, even big-endian targets have the expected byte order to find bits. - Iterators specialize methods like `fold` and `all` for performance. We should probably update to 2018 edition too, but I didn't bother yet.
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
I used critcmp to compare criterion results with the master branch. It's a little weird in that instead of just calculating from old to new, it holds the fastest one as 1.00 on each benchmark (in bold green, but the color's not showing here), and reports the ratio >1 for the other.
|
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
- Coverage 51.22% 49.45% -1.77%
==========================================
Files 17 17
Lines 3934 4531 +597
==========================================
+ Hits 2015 2241 +226
- Misses 1919 2290 +371
Continue to review full report at Codecov.
|
huonw
approved these changes
Jun 16, 2020
|
@huonw I do appreciate your review, absent or not. 🙂 If there are no further comments, I think I'll merge and publish it this afternoon. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 17, 2020
30: Big refactoring r=cuviper a=cuviper Sorry for a mega-PR, but I've been tinkering with upgrading dependencies and fixing the big-endian problems. In trying to recoup performance, all of these changes got intertwined. At a high level: - Bump all crates to 0.3 to account for breaking changes. - Upgrade to smallvec 1 -- raises the minimum Rust to 1.36. - Various dev-dependencies are upgraded as well. - `primal_bit::BitVec` now stores a `Vec<u8>`, and no longer exposes methods that depend on endianness. Fixes #10. - A lot of the wheel operations were byte-oriented already, so they really depended on little-endian order before. With `Vec<u8>`, even big-endian targets have the expected byte order to find bits. - Iterators specialize methods like `fold` and `all` for performance. We should probably update to 2018 edition too, but I didn't bother yet. Co-authored-by: Josh Stone <[email protected]>
|
err, let's try that with your review reflected, at least. |
|
bors r- |
|
Canceled. |
|
bors r=huonw |
bors bot
added a commit
that referenced
this pull request
Jun 17, 2020
30: Big refactoring r=huonw a=cuviper Sorry for a mega-PR, but I've been tinkering with upgrading dependencies and fixing the big-endian problems. In trying to recoup performance, all of these changes got intertwined. At a high level: - Bump all crates to 0.3 to account for breaking changes. - Upgrade to smallvec 1 -- raises the minimum Rust to 1.36. - Various dev-dependencies are upgraded as well. - `primal_bit::BitVec` now stores a `Vec<u8>`, and no longer exposes methods that depend on endianness. Fixes #10. - A lot of the wheel operations were byte-oriented already, so they really depended on little-endian order before. With `Vec<u8>`, even big-endian targets have the expected byte order to find bits. - Iterators specialize methods like `fold` and `all` for performance. We should probably update to 2018 edition too, but I didn't bother yet. Co-authored-by: Josh Stone <[email protected]>
|
Build failed: |
|
bors r=huonw |
bors bot
added a commit
that referenced
this pull request
Jun 17, 2020
30: Big refactoring r=huonw a=cuviper Sorry for a mega-PR, but I've been tinkering with upgrading dependencies and fixing the big-endian problems. In trying to recoup performance, all of these changes got intertwined. At a high level: - Bump all crates to 0.3 to account for breaking changes. - Upgrade to smallvec 1 -- raises the minimum Rust to 1.36. - Various dev-dependencies are upgraded as well. - `primal_bit::BitVec` now stores a `Vec<u8>`, and no longer exposes methods that depend on endianness. Fixes #10. - A lot of the wheel operations were byte-oriented already, so they really depended on little-endian order before. With `Vec<u8>`, even big-endian targets have the expected byte order to find bits. - Iterators specialize methods like `fold` and `all` for performance. We should probably update to 2018 edition too, but I didn't bother yet. Co-authored-by: Josh Stone <[email protected]>
|
Build failed: |
All good by me 👍 |
|
Great, thanks! I'm just working through CI now... bors r=huonw |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for a mega-PR, but I've been tinkering with upgrading dependencies
and fixing the big-endian problems. In trying to recoup performance, all
of these changes got intertwined. At a high level:
primal_bit::BitVecnow stores aVec<u8>, and no longer exposesmethods that depend on endianness. Fixes primal fails on big-endian machines #10.
really depended on little-endian order before. With
Vec<u8>, evenbig-endian targets have the expected byte order to find bits.
foldandallfor performance.We should probably update to 2018 edition too, but I didn't bother yet.