-
-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up dev servers; lucide-svelte
issue
#575
Comments
Go for it! |
Thanks for taking this on! 🙂 I just want to note down here (before I forget) that we'll have to validate that changing the import paths to use deep imports doesn't break our registry builder script. There's a good chance that it will, so we'll have to modify it to accommodate. I can handle that part right before we merge your PR. |
This comment has been minimized.
This comment has been minimized.
If the docs could be updated, that would be good for new users. For example I've just been trying it out today. I created a "hello world" app with some basic pages, tried adding a dark mode toggle based on https://www.shadcn-svelte.com/docs/dark-mode and noticed the build took much longer. Sure enough it was looping over every icon as part of the build, despite only needing the sun and moon icon. Making this change: //import { Sun, Moon } from 'lucide-svelte';
import SunIcon from 'lucide-svelte/icons/sun';
import MoonIcon from 'lucide-svelte/icons/moon'; ... and updating the page to match the names resulted in going from ...
... to ...
Way faster. (I could do a PR for that one page but I see there's an existing PR that looks to cover it throughout #591) |
We're tracking @gregmsanderson. There's an issue with a dependency that is holding us back at the moment but should be resolved soon. |
Current Behavior
Given lucide-icons/lucide#1707, which you also briefly touched over in the stream, I wanted to volunteer to import all
lucide-svelte
icons in the new/faster format.Expected Behavior
Steps To Reproduce
N/A
Link to Reproduction / Stackblitz (reproduction template)
No response
More Information
No response
The text was updated successfully, but these errors were encountered: