Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the S3 Endpoint correctly #877

Open
joehoyle opened this issue May 20, 2024 · 0 comments
Open

Set the S3 Endpoint correctly #877

joehoyle opened this issue May 20, 2024 · 0 comments
Labels
bug Existing functionality isn't behaving as expected

Comments

@joehoyle
Copy link
Member

Altis infra uses the global s3 endpoint of s3.amazonaws.com for all region's s3 buckets. Things like S3_Uploads::get_s3_location_for_url() also assumes a global hardcoded hostname. However, if you try to generate URLs with the SDK, it will generate $bucket.s3.$region.amazonaws.com (with the exception of us-east-1, which defaults to the global hostname) style URLs. That's an issue for things like S3 Uploads Private Media as the signature will then not match.

We should make sure that the SDK's S3Client is set to use the global hostname to ensure compatibility with the rest of the Altis infra.

@joehoyle joehoyle added the bug Existing functionality isn't behaving as expected label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Existing functionality isn't behaving as expected
Projects
None yet
Development

No branches or pull requests

1 participant