-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upon import term->parent is not correct #121
Comments
I've got a fix for this but can't yet submit a PR for it until the Simple namespace-aware parsing PR is merged because the fix for this relies on the unit tests I added in that PR. |
@dcavins Glancing thru the changes in your PR it looks like your fix is more complete than mine (one of these days I'll wrap my head around the I'll give yours a try when I get a chance and report back. |
@dcavins I just had a chance to review your PR and it passed all the tests I wrote for it. So, hopefully, it'll get merged soon. |
@pbiron Thanks for testing this PR out. It's great to have another pair of eyes look at it, and I love it when somebody's got tests to apply. 👍 |
Non-empty
<wp:category_parent>
and<wp:term_parent>
elements are not processed correctly. As a result, all imported terms haveterm->parent == 0
.The text was updated successfully, but these errors were encountered: