Work for background-image / inline

[noeltock]

Often use background-image inline to dynamically cover areas.

Thanks!

[noeltock]

Any word on this yet, somewhat unusable for most the prod environments I handle. Thanks!

[joehoyle]

Stop using background images for everything :P

[noeltock]

Ha, no.

On 12 Jan 2016, 14:43 +0100, Joe [email protected], wrote:

Stop using background images for everything :P

—
Reply to this email directly orview it on GitHub(#7 (comment)).

[rmccue]

Here's what I'm thinking:

• On elements with BG images, you'd call Gaussholder\Frontend\get_placeholder_attrs( $id, $size ) and add them to the element yourself, plus add a class like gaussholder
• You'd also call something like Gaussholder\Frontend\enqueue_script
• This script would find everything with .gaussholder and handle that for you

This would be opt-in for themes, and wouldn't affect any pages you haven't explicitly opted in to. Fair bit less automagic than normal images, but should work pretty nicely.

@noeltock Sound groovy?

[noeltock]

Yes, I like. I know it's not sexy in a traditional jQuery drop-in way, but definitely needed. Any performance or other issues you forsee doing this?

[rmccue]

The main issue will be image pop-in when the full image loads, as it'll need a different animation process. Not too concerned about the integration sexiness, as it's a developer-focussed lib/plugin anyway, and background images are going to be custom coded anyway.

[roborourke]

Just spotted this old issue after a PR review. If the background image is relevant to the content there's a CSS prop called object-fit that lets you do background image type stuff with foreground image tags: https://css-tricks.com/almanac/properties/o/object-fit/

Might need to test that method works with Gaussholder though but don't see why it shouldn't.