Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure the on-write function takes an argument #94

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

hugsy
Copy link
Owner

@hugsy hugsy commented Oct 19, 2023

Description/Motivation/Screenshots

hugsy/gef#1000 introduced a callback signature change for on-write hooks, which broke capstone.py (reported on discord). This PR fixes that

How Has This Been Tested ?

"Tested" indicates that the PR works and the unit test (i.e. make test) run passes without issue.

  • x86-32
  • x86-64
  • ARM
  • AARCH64
  • MIPS
  • POWERPC
  • SPARC
  • RISC-V

Checklist

  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code,
    adequate tests have been added.
  • I have read and agree to the
    CONTRIBUTING document.

@hugsy hugsy merged commit 4b98e62 into main Oct 19, 2023
7 checks passed
@hugsy hugsy deleted the capstone-on-write-cfg-api-fix branch October 19, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants