Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop last enabled on test set #9

Open
StefOe opened this issue Jan 31, 2024 · 0 comments
Open

drop last enabled on test set #9

StefOe opened this issue Jan 31, 2024 · 0 comments

Comments

@StefOe
Copy link

StefOe commented Jan 31, 2024

Thank you for providing this code!
I noticed that drop last is enabled for the test set, which can lead to wrong test metrics since a few samples might get ignored depending on the batch size.

https://github.com/hughxx/tsf-new-paper-taste/blob/c3ec59936943801943e03e26dd9f8ae20bf8f362/data_provider/data_factory.py#L19C9-L19C25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant