Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major rewrite in progress #51

Closed
kristianmandrup opened this issue Nov 4, 2016 · 4 comments
Closed

Major rewrite in progress #51

kristianmandrup opened this issue Nov 4, 2016 · 4 comments

Comments

@kristianmandrup
Copy link

I'm doing a major rewrite using ES6 on this flat#dev branch

The current implementation was getting out of hand and full of "garbage" to make it very difficult to make sense of. Let me know if you want to help out in this effort.
I'm planning to use flat in my json-operator

@kristianmandrup
Copy link
Author

I've been trying to compose the functionality into more granular functions, classes and encapsulated state. When it works, I would like to play with the ability to divide and conquer, ie. to process the flatten/unflatten via async tasks that are merged into the result.
Would love if someone would like to help out on this. Cheers!

@maximilianschmitt
Copy link

This is great!

@antony
Copy link

antony commented Aug 1, 2017

I've broken apart the flatten method as part of #61

I think it is worth moving some of these nested functions into separate files

@jonkoops
Copy link
Collaborator

Closing this issue as it is too abstract to really put some tasks on it. We have since re-written the source to use modern ECMAScript syntax (including modules).

Feel free to open up any PRs you think can improve the code.

@jonkoops jonkoops closed this as not planned Won't fix, can't repro, duplicate, stale Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants