Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change inputs_embeds to input_embeds #34846

Open
Luohongzhige opened this issue Nov 21, 2024 · 1 comment
Open

change inputs_embeds to input_embeds #34846

Luohongzhige opened this issue Nov 21, 2024 · 1 comment
Labels
Feature request Request for a new feature

Comments

@Luohongzhige
Copy link

Feature request

Change the inputs_embeds in the LlamaModel(Maybe others also) input parameters to input_embeds

Motivation

Our code work should be based on one of these two, and we will also switch from A to B or vice versa, and the current difference in the prefixes of the two makes the experience of this process not so good. This process can be made more convenient with simple modifications.

Your contribution

I can help to submit a PR for it

@Luohongzhige Luohongzhige added the Feature request Request for a new feature label Nov 21, 2024
@Rocketknight1
Copy link
Member

Hi @Luohongzhige, although I agree "input_embeds" is a little more grammatically correct, "inputs_embeds" is the standard in the codebase and used by all of our models. You can standardize on "inputs_embeds" and it should work with any Huggingface model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

2 participants