Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What do you all think about having a "Transformers.js Community" in Hugging Face? #512

Open
felladrin opened this issue Jan 10, 2024 · 9 comments
Labels
question Further information is requested

Comments

@felladrin
Copy link
Contributor

Question

After checking how MLX Community on Hugging Face is working, I thought it could be a good idea to have one for Transformers.js.

One of the key benefits of a community is "multiple curators": anyone in the community would have the ability to edit the repositories, which makes it easier to maintain the converted models and ensure that they have more detailed Readmes.

Also, having multiple curators allows for quicker resolution of issues with the model configuration. Members of the community won't need to create a pull request to request changes or wait for someone to approve the PR, which is especially important for urgent fixes.

Another good move the MLX community made was releasing a script that automatically uploads models to the organization in Hugging Face, which makes it easy for anyone to convert and share their favorite models.

I would love to hear the opinions of others.

@felladrin felladrin added the question Further information is requested label Jan 10, 2024
@felladrin felladrin closed this as not planned Won't fix, can't repro, duplicate, stale Feb 3, 2024
@xenova
Copy link
Collaborator

xenova commented Mar 5, 2024

Hi @felladrin! Sorry for the delayed response. I spoke with @osanseviero today about this, and turns out there's a lot of neat functionality built into community orgs that could really help increase models and usage (preferable to having it all under my account)!

One thing I think that would be necessary beforehand is to create a robust HF conversion space (#222), so users don't need to install the scripts themselves (dependency version nightmares). Do you think that's something you'd be interested in contributing?

@xenova xenova reopened this Mar 5, 2024
@felladrin
Copy link
Contributor Author

That's great news!
I'm interested in contributing!
Let me set up some PoC this week and give feedback here.
I suppose I can create it in a space under my account and then move it to the new org later 🤔

@osanseviero
Copy link

I don't think the Space would be a blocker for the org tbh! People can also run the script and upload the converted model!

That said, having a Space would be 🔥 🔥

@felladrin
Copy link
Contributor Author

felladrin commented Mar 7, 2024

Good news! I've got the space ready! https://huggingface.co/spaces/Felladrin/convert-to-onnx

Case 1. If the model hasn't been converted yet:

recording1.mov

...a few seconds later...

recording2.mov

Case 2. If the model has already been converted:

recording3.mov

To decide

File name pattern: Currently it'll upload to <org_name>/<model_creator_id>-<model_id>-ONNX. Example: TransformersJS/EleutherAI-pythia-14m-ONNX. Suggestions?

Default README.md content: Currently it doesn't write a readme, but we should. Also to include the library_name: "transformers.js" metadata.

@xenova
Copy link
Collaborator

xenova commented Mar 11, 2024

Wow this is great! 😍 As for the community name, transformers.js-community is a bit long, so how about webml-community: https://huggingface.co/webml-community ?

Can change of course.

@felladrin
Copy link
Contributor Author

felladrin commented Mar 12, 2024

webml-community fits well! 🚀

Now we just need to:

  1. Define some description for the community
  2. Define rules for the model names/cards
  3. Move the Space to the Org
  4. Announce 📢

@xenova
Copy link
Collaborator

xenova commented May 24, 2024

Sorry for taking so long to revisit this... but I've also created https://huggingface.co/onnx-community which may fit better since we'll be uploading ONNX weights for all these models, and aligns well with:

This is actually born out of the need to another place to upload Transformers.js v3 models in a way that doesn't conflict with existing models.

Feel free to request to join 🔥

@felladrin
Copy link
Contributor Author

Yeah!! Looks great!

But it seems it's not open for join-requests :D

image

Alternatively, you can invite me directly!

@felladrin
Copy link
Contributor Author

By the way, Xenova, have you thought about the name format you're planning to use for the models uploaded to ONNX Community?

onnx-community/<model_creator_id>-<model_id>-ONNX? (e.g. onnx-community/EleutherAI-pythia-14m-ONNX)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants