-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sveltekit Client + Server example #254
base: main
Are you sure you want to change the base?
Conversation
1083699
to
1a4fe2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool so far! I look forward to getting this merged.
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Co-authored-by: Joshua Lochner <[email protected]>
Co-authored-by: Joshua Lochner <[email protected]>
Co-authored-by: Joshua Lochner <[email protected]>
Co-authored-by: Joshua Lochner <[email protected]>
addressed all comments @xenova ! thanks for the review. how do you trigger the ephemeral docs build? |
I think only I can trigger it - which I have done now :) |
Updated 👍 PS: Could you grant me write access to your fork? I'll try running this on a clean linux install tomorrow to see if everything works as intended. I've never built a svelte[kit] app before, so I'm probably the perfect guinea pig! 🤣 |
@xenova perfect! thanks feel free to push anything, I think I've checked the box!! |
While playing with the server-side app, it takes a few seconds before being ready, but if the user types something before it's finished loading, it doesn't update when ready: This doesn't happen with the next-server example. Do you have an idea on how to fix it? |
hi @xenova, not sure if I can reproduce this, perhaps pinging the backend onMount to load the model? onMount(() => {
// Make a request to the /classify routem, load the model
fetch("/classify?text='Hello'");
}); |
@xenova added extra svelte, minor difference from svelteki |
Add two examples for Svelte kit client + server
Docs with walkthrough