Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upper bound for fsspec #7326

Open
fellhorn opened this issue Dec 13, 2024 · 0 comments
Open

Remove upper bound for fsspec #7326

fellhorn opened this issue Dec 13, 2024 · 0 comments

Comments

@fellhorn
Copy link

fellhorn commented Dec 13, 2024

Describe the bug

As also raised by @cyyever in #7296 and @NeilGirdhar in d546883#commitcomment-140952162 , datasets has a problematic version constraint on fsspec.

In our case this causes (unnecessary?) troubles due to a race condition bug in that version of the corresponding gcsfs plugin, that causes deadlocks: fsspec/gcsfs#643

We just use a version override to ignore the constraint from datasets, but imho the version constraint could just be removed in the first place?

The last few PRs bumping the upper bound were basically uneventful:

Steps to reproduce the bug

Expected behavior

Installing fsspec>=2024.10.0 along datasets should be possible without overwriting constraints.

Environment info

All recent datasets versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant