Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image URL detection #3054

Open
hlky opened this issue Aug 29, 2024 · 0 comments
Open

Image URL detection #3054

hlky opened this issue Aug 29, 2024 · 0 comments
Labels
improvement / optimization P2 Nice to have question Further information is requested

Comments

@hlky
Copy link

hlky commented Aug 29, 2024

is_image_url relies on a filename and extension being present, however, in some cases an image URL does not contain a filename. Example dataset and example URL. This could be improved by checking the content-type header of the response or checking for strings like "image" in the URL.

@severo severo added question Further information is requested improvement / optimization P2 Nice to have labels Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement / optimization P2 Nice to have question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants