Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warnings and fallback for unassigned devices in infer_auto_device_map #3066

Merged
merged 15 commits into from
Nov 20, 2024
Merged

Add warnings and fallback for unassigned devices in infer_auto_device_map #3066

merged 15 commits into from
Nov 20, 2024

Commits on Aug 31, 2024

  1. feat: feat: Add warning for unassigned main devices

    @Nech-C
    Nech-C committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    480d441 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. refactor: Improve warning for unassigned main devices

    @Nech-C
    Nech-C committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    4f89c26 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. feat: impl fallback_allocate; fix output format

    @Nech-C
    Nech-C committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    aefd770 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2024

  1. fix: include last dot index in the iteration

    @Nech-C
    Nech-C committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    dc6641c View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. feat: incorporate fallback allocation into infer_auto_device_map

    @Nech-C
    Nech-C committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    d607bfb View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. Revert "feat: incorporate fallback allocation into infer_auto_device_… 

    …map"

This reverts commit d607bfb.
    @Nech-C
    Nech-C committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    f040302 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. refactor: add helper functions and eliminate redundant variables 

    The fallback allocation will be reintroduced once the branching logic is fully refactored. This commit prepares the function infer_auto_device_map for further refactoring.
    @Nech-C
    Nech-C committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    9db401e View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. refactor: simplify allocation logic by removing duplicates and reduci… 

    …ng nesting
    @Nech-C
    Nech-C committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    0b52bdc View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. feat: incorporate fallback allocation into infer_auto_device_map 

    Implemented fallback allocation to allow modules to be allocated to devices using BFS when regular allocation fails. This enhancement improves the allocation process by ensuring that at least one module is assigned to the device, even under tight memory constraints.
    @Nech-C
    Nech-C committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    7ff9f26 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. fix: fix module splitting logic

    @Nech-C
    Nech-C committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    be385b0 View commit details
    Browse the repository at this point in the history

  2. styles: fix styling errors

    @Nech-C
    Nech-C committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    c6025ee View commit details
    Browse the repository at this point in the history

  3. test: add test coverage for no-warning cases 

    test_infer_auto_device_map and test_infer_auto_device_map_with_fallback_allocation now each have a no-warning test case.

Simplified and rewrote code sections that were made unreadable by the linter.
    @Nech-C
    Nech-C committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    a35776c View commit details
    Browse the repository at this point in the history

  4. refactor: simplify control flow in infer_auto_device_map 

    Added complete return type hinting for _init_infer_auto_device_map
    @Nech-C
    Nech-C committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    73dbc76 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. refactor: replace warnings.warn with logger.info for allocation failures

    @Nech-C
    Nech-C committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    5a72010 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. fix: use assertLogs to capture no allocation warning messages correctly

    @Nech-C
    Nech-C committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    c25383a View commit details
    Browse the repository at this point in the history