Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid releasing non-x.x.x versions #68

Open
dhalbert opened this issue Mar 27, 2022 · 0 comments
Open

Avoid releasing non-x.x.x versions #68

dhalbert opened this issue Mar 27, 2022 · 0 comments

Comments

@dhalbert
Copy link

I recently bought a new NanoVNA-H, which was loaded with https://github.com/hugen79/NanoVNA-H/releases/tag/1.1.

NanoVNA-Saver's Version.py did not like this x.x version number, and complained with "Unable to parse version: 1.1". The unrecognized version may have caused some problems fetching data from the NanoVNA-H: I was getting scan values that did not match what the unit was reporting on the screen.

I fixed the problem by updating to https://github.com/hugen79/NanoVNA-H/releases/tag/1.1.01.

I'm not sure whether NanoVNA-Saver should support non-x.x.x version numbers, or whether https://github.com/hugen79/NanoVNA-H should avoid non-x.x.x releases. Probably both is good. I filed an issue on NanoVNA-Saver as well: NanoVNA-Saver/nanovna-saver#483.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant