Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additionalProperties: false required at lower object levels #114

Closed
annakrystalli opened this issue Nov 1, 2024 · 1 comment
Closed
Assignees
Labels

Comments

@annakrystalli
Copy link
Member

As we've discovered in the past, if not specified explicitly, the default for objects is to allow additionalProperties. While we've addressed this at higher levels (e.g config level, output_types and target_metadata - we do allow additional properties in rounds and of course task ids) we haven't in lower level objects. This means that while we're removing optional as a valid property of output types in v4.0.0, the continued existence of optional properties is not causing a validation error.

We therefore need to add "additionalProperties": false to all lower level object specifications 🙄

@annakrystalli annakrystalli changed the title additionalProperties: false required at all levels additionalProperties: false required at lower object levels Nov 1, 2024
@annakrystalli annakrystalli self-assigned this Nov 1, 2024
@annakrystalli annakrystalli moved this from Todo to In Progress in hubverse Development overview Nov 1, 2024
@annakrystalli annakrystalli moved this from In Progress to Reviewed/Ready to Merge in hubverse Development overview Nov 1, 2024
@annakrystalli
Copy link
Member Author

Closed via #115

@github-project-automation github-project-automation bot moved this from Reviewed/Ready to Merge to Done in hubverse Development overview Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

1 participant