Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disallow optional values in pmf output_type specifications #100

Closed
nickreich opened this issue Sep 26, 2024 · 0 comments · Fixed by #103
Closed

disallow optional values in pmf output_type specifications #100

nickreich opened this issue Sep 26, 2024 · 0 comments · Fixed by #103
Assignees

Comments

@nickreich
Copy link
Contributor

nickreich commented Sep 26, 2024

Per https://github.com/orgs/hubverse-org/discussions/24,
the thinking here is that it does not make sense for a hub to allow submissions where some pmf output_type_id fields are optional.

Another concern is that for ordered pmf targets it is important to be able to sort the bin names into an order but the order may not be alphanumeric. If the bin names are spread out within separate required and optional lists then it is not easy to know how to sort them.

@annakrystalli annakrystalli self-assigned this Sep 27, 2024
@annakrystalli annakrystalli mentioned this issue Oct 9, 2024
@annakrystalli annakrystalli linked a pull request Oct 9, 2024 that will close this issue
@annakrystalli annakrystalli moved this from In Progress to Ready for Review in hubverse Development overview Oct 9, 2024
@annakrystalli annakrystalli moved this from Ready for Review to In Progress in hubverse Development overview Oct 9, 2024
@annakrystalli annakrystalli moved this from In Progress to Ready for Review in hubverse Development overview Oct 9, 2024
@annakrystalli annakrystalli moved this from Ready for Review to Reviewed/Ready to Merge in hubverse Development overview Oct 16, 2024
@github-project-automation github-project-automation bot moved this from Reviewed/Ready to Merge to Done in hubverse Development overview Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants