Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output error/warning/message when model output updated #65

Closed
LucieContamin opened this issue Dec 6, 2023 · 2 comments
Closed

Output error/warning/message when model output updated #65

LucieContamin opened this issue Dec 6, 2023 · 2 comments

Comments

@LucieContamin
Copy link
Contributor

Following the issue #44 and the PR #63, I wonder if the test to check for modifications/deletion of a previously submitted model output files should have an additional parameter with the possibility to have the check either:

  • returning an error and failing the validation
  • OR returning a warning/message and passing the validation

I am thinking for the Scenario projection hubs, it happen sometimes that a team wants to update their submission during an ongoing run and in this case we will allow the team to modify(or even remove) their submission.

We can technically bypass the failed validation and still merge the PR manually but I think it might be more clear to the team submitting to have a message/warning than an error (in the case we allow modification)

@elray1
Copy link
Contributor

elray1 commented Dec 6, 2023

Another similar idea could be to (provide an option to) allow changes as long as the submission window has not expired... Though maybe in that case this check would just be turned off as its pass/fail results would be equivalent to the submission window check?

@LucieContamin
Copy link
Contributor Author

It might still be interesting to know that it's an update of a submission in an ongoing round.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants