Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When implementing weighted sampling, check that weights only vary by compound_taskid_set #149

Open
lshandross opened this issue Dec 12, 2024 · 1 comment · May be fixed by #147
Open

When implementing weighted sampling, check that weights only vary by compound_taskid_set #149

lshandross opened this issue Dec 12, 2024 · 1 comment · May be fixed by #147

Comments

@lshandross
Copy link
Contributor

lshandross commented Dec 12, 2024 •
edited
Loading

when we get to weighted sampling, maybe we need to check that the weights only vary by things in the compound_taskid_set, not on other variables. e.g., if we are collecting trajectories we can't give different weights to models at different horizons. I know we're not handling weighted sampling in this PR, just thinking about it now. OK to file this as an issue for later.

Originally posted by @elray1 in #147 (comment)
@lshandross lshandross linked a pull request Dec 12, 2024 that will close this issue
Open
lshandross added a commit that referenced this issue Dec 13, 2024
@lshandross
Validation for sample weights by compound task ID set, instead of onl…
32d3988 
…y by model (#149)

Note, though, that a weighted linear pool for samples has not yet been implemented
@lshandross
Copy link
Contributor Author

Ended up realizing I could implement this validation by a small change to an out-dated one in validate_sample_inputs(), so I changed it in #147

@lshandross lshandross linked a pull request Dec 13, 2024 that will close this issue
Ls/standardize compound unit for samples/144 #147
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
hubverse Development overview
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ls/standardize compound unit for samples/144 hubverse-org/hubEnsembles
1 participant
@lshandross