Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove numpy from this project #174

Open
zkamvar opened this issue Sep 5, 2024 · 5 comments
Open

remove numpy from this project #174

zkamvar opened this issue Sep 5, 2024 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@zkamvar
Copy link
Member

zkamvar commented Sep 5, 2024

I am having a bear of a time trying to get things installed on my Mac and one thing that's causing me a headache right now is numpy, which was introduced in ebc22d6.... I don't think we actually use numpy anywhere. Could we remove it?

@micokoch
Copy link
Contributor

micokoch commented Sep 5, 2024

I added this requirement when trying to make a few changes to HubDocs (in #74, where I did too many things for a single PR). I'm sure I copied those requirements from somewhere, but I can't remember where or what the justification was - other than to make it all work. I don't know if removing it would make anything break (maybe on the back end of the Sphinx Read the Docs template?), but I'm okay with testing and seeing if anything bad happens.

@bsweger
Copy link
Contributor

bsweger commented Sep 5, 2024

This is why I'm a big fan of generating requirements files with pip-compile or uv pip compile. Looks like numpy isn't being directly imported in our code, but it could be a transitive dependency.

In this case, requirements.txt doesn't give us the answer (one reason why I'm a fan of generating requirements files with pip-compile or uv pip compile, which generate an annotated requirements file).

Shouldn't be too hard to investigate, though. If numpy is truly not needed, we would be nice to get it out!

@bsweger
Copy link
Contributor

bsweger commented Sep 6, 2024

@zkamvar Quick question for prioritizing--is having numpy in this repo a blocker for you?

@zkamvar
Copy link
Member Author

zkamvar commented Sep 9, 2024

It is no longer a blocker.

@bsweger
Copy link
Contributor

bsweger commented Sep 9, 2024

Thanks--will still keep this on the list, because I'm guessing that we really don't need numpy here!

@micokoch micokoch added the documentation Improvements or additions to documentation label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Todo
Development

No branches or pull requests

3 participants