Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only allow a single target_keys key value pair to conform to v4.0.1 schema #89

Open
2 tasks done
annakrystalli opened this issue Dec 18, 2024 · 0 comments · May be fixed by #90
Open
2 tasks done

Only allow a single target_keys key value pair to conform to v4.0.1 schema #89

annakrystalli opened this issue Dec 18, 2024 · 0 comments · May be fixed by #90
Assignees
@annakrystalli
Labels
v4.0.1

Comments

@annakrystalli
Copy link
Member

annakrystalli commented Dec 18, 2024 •
edited
Loading

In v4.0.1, we only allowing a single target_keys key value pair.

To ensure hubAdmin functionality conform to this pattern we need to:

  • Add a test that demonstrates correct identification of more that 1 target_keys key value pair when validating task.json files with validate_config()
  • Ensure an error is thrown when creating target_keys with more that 1 key value pair programmatically

Related to hubverse-org/schemas#117
@annakrystalli annakrystalli self-assigned this Dec 18, 2024
@annakrystalli annakrystalli moved this from Todo to In Progress in hubverse Development overview Dec 18, 2024
annakrystalli added a commit that referenced this issue Dec 18, 2024
@annakrystalli
Add test that confirms config files with 1 target_keys key value pair…
fec895a 
… do not pass validation. Resolves #89
annakrystalli added a commit that referenced this issue Dec 18, 2024
@annakrystalli
Do not allow target_keys of length more than 1 in v4.0.1 and above wh…
6192af2 
…en creating programmatically. Rsolves #89
@annakrystalli annakrystalli linked a pull request Dec 18, 2024 that will close this issue
Open
@annakrystalli annakrystalli moved this from In Progress to Ready for Review in hubverse Development overview Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@annakrystalli annakrystalli

Labels
v4.0.1
Projects
hubverse Development overview
Status: Ready for Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only allow a single target_keys key value pair hubverse-org/hubAdmin
1 participant
@annakrystalli