-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up tasks.json #1
Comments
|
|
|
Re: the Regarding the |
One question I had is, if a given round has |
As a given round should only have 1 id, the id is shared for all specification associated with this round. I think having the |
I think Anna's second comment here was more related to a forecast hub example where the round id corresponds to the value of a task id variable. I agree that in that kind of settings, the variable that is used as a |
Yes definitely. It's just that for a given model task, there can be multiple sets of valid task_id combinations. E.g. in this example, there are two elements in model_tasks (groups of task_ids & output_types) that differ in the target variable & cdf specification: https://github.com/annakrystalli/hub-infrastructure-experiments/blob/bcb116d5f438f7ff217db74659c9d6bd5b4d274b/json-schema/modified-hubmeta-examples/complex-hubmeta-mod.json#L4-L110 I just wanted to double check that there is absolutely no situation when one of these groups does not contain the round_id variable as a task_id variable. |
In this case, the |
In the case of one of the complex example (like the one @annakrystalli shared), I agree with @elray1 , we will have a On the forecast hub example with |
OK great! Regarding the |
OK, so to wrap up the original question -- I think that what we want to do is add |
Yup! It's what's currently implemented. |
ok, sounds good. Thank you! |
A couple of things I noticed about the draft
tasks.json
file we put together:#/$defs/task_ids/quantile/quantile
. This is not technically wrong in the sense that the reference can be resolved without issue. But it may be confusing to readers because quantiles are not a task id, but are rather a part of the output representation specification."round_id_from_variable": false
flagThe text was updated successfully, but these errors were encountered: